CI: Separate jobs to build and deploy documentation #3767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
force-pushed
the
ci/deploy-docs
branch
from
00ab410 to
689ee4c
Compare
seisman
force-pushed
the
ci/deploy-docs
branch
from
689ee4c to
78bf149
Compare
Member
Author
|
One disadvantage is that, the deployment job starts only after all the three matrix jobs in the Considering that the Windows job takes much longer (~ 7 minutes) than the Linux/macOS jobs (~ 3 minutes), maybe having separate jobs is not a good idea? |
Member
Author
|
Let's keep it in a single job now. Will revisit this PR later. |
seisman
force-pushed
the
ci/deploy-docs
branch
2 times, most recently
from
eef1a0b to
c0b595c
Compare
seisman
force-pushed
the
ci/deploy-docs
branch
2 times, most recently
from
527a796 to
6c5be6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3742, it makes more sense to build and deploy documentation in separate jobs.
This PR splits the
ci_docs.yamlworkflow into two jobs:build-docs: Build the documentation and upload the HTML files as artifactsdeploy-docs: Download the HTML artifacts and deploy to the gh-pages branchThe HTML artifacts can also be uploaded as release assets when making a release. It will be done in separate PRs (addressing #3731).