clib.Session: Add type hints and reformat docstrings (part 1) #3504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
commented
Oct 10, 2024
Comment on lines
-120
to
-121
| A ``GMTVersionError`` exception will be raised if the GMT shared library | ||
| reports a version older than the required minimum GMT version. |
Member
Author
There was a problem hiding this comment.
This sentence is remove since it's no longer valid after PR #3254.
michaelgrund
approved these changes
Oct 11, 2024
seisman
removed
the
final review call
seisman
added a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No code changes, just add type hints and format docstrings.