load_tile_map: Register the rio accessor by importing rioxarray so the returned raster has CRS #3323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e returned raster has CRS
seisman
added
bug
weiji14
reviewed
Jul 10, 2024
Member
There was a problem hiding this comment.
Have manually triggered the doctests CI for this branch (which has rioxarray installed) at https://github.com/GenericMappingTools/pygmt/actions/runs/9867651036/job/27248357251, looks ok, but a couple of suggestions.
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Wei Ji <[email protected]>
seisman
force-pushed
the
tilemap/rioxarray
branch
from
41a660b to
9ecc39d
Compare
seisman
commented
Jul 10, 2024
weiji14
reviewed
Jul 10, 2024
Co-authored-by: Wei Ji <[email protected]>
weiji14
approved these changes
Jul 10, 2024
Comment on lines
124
to
+127
| spatial_ref int64 ... 0 | ||
| >>> # CRS is set only if rioxarray is available | ||
| >>> if hasattr(raster, "rio"): | ||
| ... raster.rio.crs |
Member
There was a problem hiding this comment.
To be honest, we probably don't need the if hasattr(raster, "rio") check, because the spatial_ref int64 ... 0 line above (added in #3321) already means that rioxarray is used (the doctests CI run with rioxarray installed). But I guess it'll be good to mention rioxarray somewhere in the docstring, albeit indirectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
rioaccessor is only registered when rioxarray is imported. Currently, we import rioxarray inFigure.tilemap(pygmt/pygmt/src/tilemap.py
Line 12 in 3a32169
load_tile_map. Thus, the raster returned byload_tile_mapalone may have CRS set or not, depending on if a script importsrioxarrayor not elsewhere.This PR fixes the issue by importing the rioxarray package in
pygmt/datasets/tile_map.pyso that therioaccessor is always registered when rioxarray is installed.