Skip to content

Fix failing tests for legacy GMT versions #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 28, 2024
Merged

Fix failing tests for legacy GMT versions #3021

merged 11 commits into from
Jan 28, 2024

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jan 27, 2024

Description of proposed changes

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 27, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 27, 2024
@seisman seisman changed the title WIP: Fix failing tests in the GMT Legacy Tests workflow Fix failing tests for legacy GMT versions Jan 27, 2024
@seisman seisman marked this pull request as ready for review January 27, 2024 12:34
seisman
seisman commented Jan 27, 2024
View reviewed changes
seisman
seisman commented Jan 27, 2024
View reviewed changes
pygmt/tests/test_datasets_earth_relief.py
npt.assert_allclose(data.coords["lon"].data.min(), -10)
npt.assert_allclose(data.coords["lon"].data.max(), -9.8)
npt.assert_allclose(data.min(), -2131.9, atol=0.5)
npt.assert_allclose(data.min(), -2069.85, atol=0.5)
Copy link
Member Author

@seisman seisman Jan 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As reported in #2511, there must be some bugs in GMT 6.5.0, so mark the test as xfail for GMT>=6.5.0.

pygmt/tests/test_x2sys_cross.py


@pytest.mark.usefixtures("mock_x2sys_home")
@pytest.mark.xfail(
Copy link
Member Author

@seisman seisman Jan 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment #2986 (comment).

@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 27, 2024
@seisman seisman merged commit e90b987 into main Jan 28, 2024
@seisman seisman deleted the legacy branch January 28, 2024 15:11
@seisman seisman removed the needs review This PR has higher priority and needs review. label Jan 28, 2024
@seisman seisman mentioned this pull request Jan 28, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14