Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Jan 12, 2024

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jan 12, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 12, 2024
@seisman seisman marked this pull request as ready for review January 12, 2024 12:39
@seisman seisman added the needs review This PR has higher priority and needs review. label Jan 12, 2024
@seisman
Copy link
Member Author

seisman commented Jan 13, 2024

ReadTheDocs CI fails because it can't access some external resources, thus we have to remove some gallery examples (70d53af) to make ReadTheDocs build work again. Need to revert commit 70d53af later.

in the base environment. Installing Miniforge does not require administrative rights to
your computer and doesn't interfere with any other Python installations on your system.

## Which GMT?
Copy link
Member Author

@seisman seisman Jan 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Markdown file is equivalent to the old ReST file, except that I changed:

PyGMT requires Generic Mapping Tools (GMT) >=6.3.0 since there are many changes being made to GMT itself in response to the development of PyGMT, mainly the new modern execution mode.

to

PyGMT requires Generic Mapping Tools (GMT) >=6.3.0 since there are many changes being made to GMT itself in response to the development of PyGMT.

mainly because PyGMT users don't have to know about GMT modern mode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new link is at https://docs.generic-mapping-tools.org/6.5/reference/introduction.html#modern-and-classic-mode, but yeah, should be ok to remove this part since GMT 6 has been around for 3+ years now.

@seisman seisman requested a review from a team January 15, 2024 04:22
"colon_fence", # Allow code fences using colons
"substitution", # Allow substituitions
]
myst_substitutions = {
Copy link
Member

@weiji14 weiji14 Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
myst_substitutions = {
# These enable substitutions using {{ key }} in the Markdown files
myst_substitutions = {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

myst_substitutions's syntax is {{ key }} and is only available in myst-markdown files. I've updated the suggestion.

Comment on lines -158 to -163
# These enable substitutions using |variable| in the rst files
rst_epilog = f"""
.. |year| replace:: {year}
.. |requires_python| replace:: {requires_python}
.. |requires_gmt| replace:: {requires_gmt}
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to remove. Looks like we only use {year} in the copyright line at L143 above.

@weiji14 weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Jan 15, 2024
@seisman seisman merged commit 32edad0 into main Jan 15, 2024
@seisman seisman deleted the rst2md/install branch January 15, 2024 08:25
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Link Checker Report on 2024-01-14

3 participants