Skip to content

Update maintainers guides #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 28, 2023
Merged

Update maintainers guides #2916

merged 6 commits into from
Dec 28, 2023

Conversation

@seisman
Copy link
Member

@seisman seisman commented Dec 26, 2023 •
edited by yvonnefroehlich
Loading

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Dec 26, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 26, 2023
weiji14
weiji14 reviewed Dec 27, 2023
View reviewed changes
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 27, 2023
@seisman
Copy link
Member Author

seisman commented Dec 27, 2023

@weiji14 Do you want to add a section like "Continuous Benchmark" to this guide?

@weiji14
Copy link
Member

weiji14 commented Dec 27, 2023

@weiji14 Do you want to add a section like "Continuous Benchmark" to this guide?

I did think about it when writing the docs in #2908, but wasn't sure what to include yet in terms of guidelines. Maybe after a few weeks/months when we've got some experience with benchmarking, then we can add some words in.

@seisman
Copy link
Member Author

seisman commented Dec 27, 2023

@weiji14 Do you want to add a section like "Continuous Benchmark" to this guide?

I did think about it when writing the docs in #2908, but wasn't sure what to include yet in terms of guidelines. Maybe after a few weeks/months when we've got some experience with benchmarking, then we can add some words in.

Sounds good.

@weiji14 weiji14 mentioned this pull request Dec 27, 2023
Closed
yvonnefroehlich
yvonnefroehlich reviewed Dec 27, 2023
View reviewed changes
@seisman @yvonnefroehlich
Update doc/maintenance.md
2e35b70 
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 28, 2023
@seisman seisman merged commit d292e30 into main Dec 28, 2023
@seisman seisman deleted the doc/maintenance branch December 28, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

@yvonnefroehlich yvonnefroehlich yvonnefroehlich approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@seisman @weiji14 @yvonnefroehlich