Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Mar 17, 2023

Description of proposed changes

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman force-pushed the timestamp-improve-docs branch from e1e4fc3 to aad50f8 Compare March 17, 2023 06:36
Co-authored-by: Michael Grund <[email protected]>
@seisman seisman added documentation Improvements or additions to documentation needs review This PR has higher priority and needs review. skip-changelog Skip adding Pull Request to changelog labels Mar 17, 2023
@seisman seisman added this to the 0.9.0 milestone Mar 17, 2023
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the suggestion it's looks good.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 17, 2023
Co-authored-by: Yvonne Fröhlich <[email protected]>
@seisman seisman merged commit badc714 into main Mar 18, 2023
@seisman seisman deleted the timestamp-improve-docs branch March 18, 2023 10:50
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants