Remove deprecated codecov dependency from CI #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiji14
force-pushed
the
codecov-v2-uploader
branch
from
b468d31 to
dedf242
Compare
The codecov-python package is being deprecated, see codecov/codecov-python#325.
weiji14
force-pushed
the
codecov-v2-uploader
branch
from
dedf242 to
19015ab
Compare
This was referenced Sep 14, 2021
weiji14
changed the title
weiji14
added
the
final review call
weiji14
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
The codecov python package is deprecated in favour of a bash script, so it should be removed from PyGMT's CI dependency lists. For more info, see codecov/codecov-python#325 and https://about.codecov.io/blog/codecov-uploader-deprecation-plan. * Refresh codecov badge to be the official one * Drop deprecated codecov dependency from conda install * Add note to maintenance.md on how code coverage reports are handled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
codecovpython package is deprecated in favour of a bash script, so it should be removed from PyGMT's CI dependency lists. See codecov/codecov-python#325 and https://about.codecov.io/blog/codecov-uploader-deprecation-plan/ for more information.Note that PyGMT's code coverage reports are currently generated using
pytest-cov(which produces acoverge.xmlfile), with the reported uploaded to https://app.codecov.io/gh/GenericMappingTools/pygmt/ usingcodecov-action. So there hasn't been any real use of installing thecodecovPyPI package on local development environments.Closes #1482
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version