Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 20, 2021

Description of proposed changes

This PR bumps the GMT version used in the CI tests to 6.2.0rc1. The minimum required GMT version is still 6.1.1 and will be bumped to 6.2.0 after GMT v6.2.0 is released.

The documentation pass, and the tests fail, as expected.

#1217.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Apr 20, 2021
@seisman seisman added this to the 0.4.0 milestone Apr 20, 2021
@seisman seisman mentioned this pull request Apr 21, 2021
3 tasks
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 21, 2021
Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks also good to me. No further suggestions from my side.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 21, 2021
@seisman seisman merged commit 1489b5f into master Apr 21, 2021
@seisman seisman deleted the bump-6.2.0rc1 branch April 21, 2021 19:13
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Jun 6, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants