-
Notifications
You must be signed in to change notification settings - Fork 234
Description
We have to decide whether we want to add quotes to all arguments, e.g., '05m' or 05m. Originally posted in #976 (comment).
We use quotes for many arguments, e.g.,
pygmt/pygmt/datasets/earth_relief.py
Lines 34 to 39 in afe9293
| resolution : str | |
| The grid resolution. The suffix ``d``, ``m`` and ``s`` stand for | |
| arc-degree, arc-minute and arc-second. It can be ``'01d'``, ``'30m'``, | |
| ``'20m'``, ``'15m'``, ``'10m'``, ``'06m'``, ``'05m'``, ``'04m'``, | |
| ``'03m'``, ``'02m'``, ``'01m'``, ``'30s'``, ``'15s'``, ``'03s'``, | |
| or ``'01s'``. |
Meanwhile, we don't use quotes in some cases, e.g.,
pygmt/pygmt/datasets/earth_relief.py
Lines 44 to 45 in afe9293
| Required for Earth relief grids with resolutions higher than 5 | |
| arc-minute (i.e., ``05m``). |
We could refer to other projects posted in #976 (comment)
Just checked other projects, numpy (https://numpy.org/doc/stable/reference/generated/numpy.datetime_as_string.html#numpy.datetime_as_string), pandas (https://pandas.pydata.org/docs/reference/api/pandas.read_csv.html) and matplotlib (https://matplotlib.org/stable/api/legend_api.html) use
'string', not'string'.