grdinfo -C now also includes registration #3359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, wihle grdinfo t.grd reports a line about the node registration, there was no such item when we asked for a numerical record -C. So no way of easily determining if a grid is pixel or gridline in a script, other than grepping on the text output. Because the order of outputs were set a long time ago, this PR just adds registration as the very last item of the record.
seisman
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
May 27, 2020
In GMT 6.1, `grdinfo` also reports registration code at the end of the output. See GenericMappingTools/gmt#3359 for upstream changes.
seisman
added a commit
to GenericMappingTools/pygmt
that referenced
this pull request
May 28, 2020
In GMT 6.1, `grdinfo` also reports registration code at the end of the output. See GenericMappingTools/gmt#3359 for upstream changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, while
grdinfo t.grdreports a line about the node registration, there was no such item when we asked for a numerical record via -C. So no way of easily determining if a grid is pixel or gridline in a script, other than grepping on the text output. Because the order of outputs was set a long time ago, this PR just adds the missing registration (0 = gridline, 1 = pixel) as the very last item of the record.