Skip to content

Remove packages lock files #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Remove packages lock files #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d588d8b
remove packages.lock.json files till we have a fixed sdk
dawedawe Sep 26, 2023
2998d92
set RestorePackagesWithLockFile and RestoreLockedMode to false in Dir…
dawedawe Sep 26, 2023
a4b635e
adjust to latest master in SDK
dawedawe Sep 26, 2023
351a8bc
Revert "adjust to latest master in SDK"
dawedawe Sep 26, 2023
519ddfa
switch to the package references
dawedawe Sep 26, 2023
95d1544
remove build of SDK from ci.yml
dawedawe Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,10 @@ jobs:
ci:
runs-on: ubuntu-latest
steps:
# Ionide SDK
- name: Checkout ionide/FSharp.Analyzers.SDK
uses: actions/checkout@v3
with:
repository: ionide/FSharp.Analyzers.SDK
path: FSharp.Analyzers.SDK
ref: master
- name: Setup .NET for ionide/FSharp.Analyzers.SDK
uses: actions/setup-dotnet@v3
with:
global-json-file: FSharp.Analyzers.SDK/global.json
- name: Build ionide/FSharp.Analyzers.SDK
working-directory: FSharp.Analyzers.SDK
run: dotnet fsi build.fsx

# G-Research analyzers
- uses: actions/checkout@v3
with:
path: g-research-fsharp-analyzers
- name: Setup .NET for ionide/FSharp.Analyzers.SDK
- name: Setup .NET
uses: actions/setup-dotnet@v3
with:
global-json-file: g-research-fsharp-analyzers/global.json
Expand Down
4 changes: 2 additions & 2 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ F# analyzers used within G-Research.
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
<WarningsAsErrors>FS0025</WarningsAsErrors>
<WarnOn>1182;3390;$(WarnOn)</WarnOn>
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<RestoreLockedMode>true</RestoreLockedMode>
<RestorePackagesWithLockFile>false</RestorePackagesWithLockFile>
<RestoreLockedMode>false</RestoreLockedMode>
<NoWarn>NU1603;NETSDK1057</NoWarn>
<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
<!-- https://www.gresearch.co.uk/blog/article/improve-nuget-restores-with-static-graph-evaluation/ -->
Expand Down
3 changes: 2 additions & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
<Project>
<PropertyGroup>
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
<RestorePackagesWithLockFile>true</RestorePackagesWithLockFile>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
</PropertyGroup>
<ItemGroup>
<!-- locking the version of F# Core as FCS does this anyway and in practise all will be using the same version -->
<PackageVersion Include="FSharp.Analyzers.SDK" Version="0.14.1" />
<PackageVersion Include="FSharp.Analyzers.SDK.Testing" Version="0.14.1" />
<PackageVersion Include="FSharp.Core" Version="[7.0.400]" />
<PackageVersion Include="FSharp.Compiler.Service" Version="[43.7.400]" />
<PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" />
Expand Down
5 changes: 1 addition & 4 deletions src/FSharp.Analyzers/FSharp.Analyzers.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,9 @@
<Compile Include="StringAnalyzers.fs"/>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\..\FSharp.Analyzers.SDK\src\FSharp.Analyzers.SDK\FSharp.Analyzers.SDK.fsproj"/>
</ItemGroup>

<ItemGroup>
<PackageReference Update="FSharp.Core"/>
<PackageReference Include="FSharp.Analyzers.SDK" />
<PackageReference Include="FSharp.Compiler.Service"/>
</ItemGroup>

Expand Down
Loading