Refreshed test_crossref_journalquality_fields_filtering cassette
#1060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
requested review from
whitead,
mskarlin,
maykcaldas,
SamCox822 and
nadolskit
There was a problem hiding this comment.
Pull Request Overview
This PR updates a test cassette for the test_crossref_journalquality_fields_filtering test to ensure it returns the correct DOI when querying Crossref. The test now includes an author parameter to specifically target DOI 10.1056/nejmoa2404204 instead of an incorrect match.
- Adds author filtering parameter to the Crossref query in the test
- Refreshes the corresponding test cassette with updated API responses
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_clients.py | Adds authors=["Johanne Silvain"] parameter to the Crossref query to ensure correct DOI matching |
| tests/cassettes/test_crossref_journalquality_fields_filtering.yaml | Updated cassette with new API responses including the author query parameter |
dosubot
bot
added
the
size:XS
whitead
approved these changes
Aug 11, 2025
jamesbraza
added a commit
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without specifying
authors, when refreshing the cassette Crossref now matches DOI 10.36106/ijar/1907236, instead of the intended DOI 10.1056/nejmoa2404204.