-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix dependency error on a non-existent argument when registration or resetting feature is disabled #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2ee1a33 to
38de48d
Compare
|
@XWB please review |
|
Why would you disable the resetting feature in the recipe? What needs to be done is adding templating to framework.yml file. |
|
There are 3 problems with recipe:
and this configuration: fos_user:
registration:
confirmation:
enabled: false
resetting: falsewill remove requirement to |
|
Anyway this PR fixes a bug since #2639, it is not about recipe for Flex, but it could help with creating recipe, of course =) |
38de48d to
221e0bf
Compare
|
I've temporary modified tests to show errors. See travis build |
731503b to
c2c9f01
Compare
|
PR was rewritten, please review. This PR fixes two bugs with non-existent parameter if registration or resetting feature is disabled. I've added tests, and PR is now ready again =) |
| 'user_class' => 'fos_user.model.user.class', | ||
| ), | ||
| )); | ||
| $container->setParameter('fos_user.from_email', array($config['from_email']['address'] => $config['from_email']['sender_name'])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't create a new fos_user.from_email. Instead, set dummy values for these emails in case the other features are not used (they won't be used anyway in such case) or set the parameters directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stof fixed. i've put dummy values to mailer.xml
c2c9f01 to
c068171
Compare
If resetting feature is disabled, error
The service "fos_user.mailer.default" has a dependency on a non-existent parameter "fos_user.resetting.email.from_email"is occured, when trying to send email.A similar error occured when registration feature is disabled, but for
fos_user.registration.confirmation.from_emailparameter.This PR fixes this bug