Commands as services #2634
Merged
Commands as services #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any clue why Scrutinizer failed? |
ossinkine
force-pushed
the
issue-2634
branch
from
b8cb0bc to
7571dfa
Compare
Author
|
@XWB I've just rebased the PR and Scrutinizer has passed |
Author
|
And also I've replaced service id with FQCN |
stof
requested changes
Nov 29, 2017
Resources/config/commands.xml
Outdated
| <service id="FOS\UserBundle\Command\ActivateUserCommand" class="FOS\UserBundle\Command\ActivateUserCommand"> | ||
| <tag name="console.command" /> | ||
| </service> | ||
| <service id="FOS\UserBundle\Command\ChangePasswordCommand" class="FOS\UserBundle\Command\ChangePasswordCommand"> |
Member
There was a problem hiding this comment.
please don't use FQCN as service ids. We don't want to register these classes in the autowirable types
Resources/config/commands.xml
Outdated
| <tag name="console.command" /> | ||
| </service> | ||
| <service id="FOS\UserBundle\Command\ChangePasswordCommand" class="FOS\UserBundle\Command\ChangePasswordCommand"> | ||
| <tag name="console.command" /> |
Member
There was a problem hiding this comment.
please add the command attribute with the command name in all tags, so that commands can be lazy-loaded in Symfony 3.4+
ossinkine
force-pushed
the
issue-2634
branch
from
7571dfa to
b60b470
Compare
Author
|
@stof Please review |
stof
approved these changes
Nov 29, 2017
Member
|
Thanks. |
|
@XWB May we have a new patch release for this? Symfony 4 is stable from a while and commands does not appears with the current stable version of this bundle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the bundle for Symfony 4.0
Relates to #2632