Upgraded all dependencies removing alpha and beta versions #18
Conversation
benatespina
force-pushed
the
feature/upgrade-dependencies
branch
from
685a48b to
92cd2fa
Compare
benatespina
force-pushed
the
feature/upgrade-dependencies
branch
from
92cd2fa to
59bc687
Compare
CHANGELOG.md
Outdated
| - [BC BREAK] Removed support for React and ReactDOM < 16.3 (Context API is not supported in those versions) | ||
| - Added React component testing using `react-testing-library` | ||
| - Increased the test code coverage | ||
| - Upgraded all dependencies removing alpha and beta versions |
There was a problem hiding this comment.
v0.8.0 was already published.
This should go in v0.8.1
There was a problem hiding this comment.
mmmm ok, I didn't know that the v0.8.0 was already published. So, first of all we should tag this version in GitHub's releases
There was a problem hiding this comment.
Moreover, we can merge this PR without publishing any new release. It's a bug-fix...
There was a problem hiding this comment.
Yes, it's a bugfix. Therefore it should be 0.8.1 instead of 0.9.0
There was a problem hiding this comment.
mmmm ok, I didn't know that the v0.8.0 was already published. So, first of all we should tag this version in GitHub's releases
Yes, I forgot to tag it in GitHub 😓
There was a problem hiding this comment.
jajaja sorry I'd want to say that it's NOT a bugfix, in the end you can work properly with master current dependencies.
| pathFromRouteForPathsAndLocale, | ||
| ), | ||
| renderTranslatedRoutesForCurrentConfig = renderTranslatedRoutesForConfig( | ||
| configRoute, |
There was a problem hiding this comment.
I would move this changes to another PR.
Changes look great but I would add tests for renderTranslatedRoutes to ensure we are not breaking anything
|
@gorkalaucirica ping |
2 participants
Uh oh!
There was an error while loading. Please reload this page.