Skip to content

Conversation

Skptak
Copy link
Contributor

@Skptak Skptak commented Jan 5, 2024

Description

Use Unix/GNU Sort instead of MacOS sort. MacOS version of sort will put capital letters at the end, GNU sort does not.
Add new common spelling words to the cSpellWordList to account for the issue mentioned in FreeRTOS/CI-CD-Github-Actions#99

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner January 5, 2024 19:26
DPROJECT
drbg
Drbg
DRBG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain where Unix/GNU Sort is used?
Could you please also explain in the commit message why it was changed.
All I see in this PR is a number of words added to .github/.cSpellWords.txt.
Thanks

BBOOL
blinky
Blinky
cbmc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain in the commit message what prompted the addition of these new words?

CSRS
ctest
Customisation
DCMAKE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain the commit message better as Merge branch 'main' into updateWordList is not very clear why these words are added?

@Skptak Skptak closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants