fix: support zero-length clientId #331
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Ryan-CW-Code
commented
Oct 24, 2025
| LogError( ( "Client ID length and value mismatch." ) ); | ||
| status = MQTTBadParameter; | ||
| } | ||
| else if( ( pConnectInfo->clientIdentifierLength == 0U ) && ( pConnectInfo->cleanSession == false ) ) |
There was a problem hiding this comment.
The preceding if already ensures that when clientIdentifierLength is 0, pClientIdentifier must be either NULL or '\0'. Therefore, this if does not need to repeat those conditions. However, I am not sure whether this simplification might cause difficulties in reading and understanding.
|
There are a couple failing checks which I'll address by overlaying a couple commits on top of your code. |
AniruddhaKanhere
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.