resolve Wconversion related warnings #935
Conversation
|
/bot run uncrustify |
|
Hi @timaydin There are some CI checks failure, can you please help in checking them. Thank You |
|
/bot run uncrustify |
| if( pucPtr[ 0U ] == tcpTCP_OPT_SACK_A ) | ||
| { | ||
| ucLen -= 2U; | ||
| ucLen -= 2; |
There was a problem hiding this comment.
I am unsure about this change. ucLen is unsigned. Then while assigning 2 to it, why not make 2 explicitly signed by using U?
There was a problem hiding this comment.
This will also give MISRA violation.
| prvReadSackOption( pucPtr, ( size_t ) lIndex, pxSocket ); | ||
| lIndex += 8; | ||
| ucLen -= 8U; | ||
| ucLen -= 8; |
There was a problem hiding this comment.
This is not solving the issue . Earlier warning was "conversion from ‘unsigned int’ to ‘uint8_t’" with your fix the warning has now changed to conversion from ‘int’ to ‘uint8_t’
|
Hi @timaydin I was reproducing the issue and i can see that there are 40+ warning with enabling Wconverstion. Were you seeing the same number of issue? If not can you let us know how you reproduced the issue? |
3 participants
Description
Avoid warnings produced as a result of -Wconversion option to gcc