Skip to content

IPv4/single: some minor comments after the MISRA changes #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 20, 2023
Merged

IPv4/single: some minor comments after the MISRA changes #531

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0a797da
IPv4/single: some minor comments after the MISRA changes
Jul 30, 2022
300fe3f
Added the "V" in the version macro
Jul 30, 2022
cb2f248
Corrected the call to memset()
Jul 30, 2022
ad270db
Update source/FreeRTOS_DNS_Networking.c
htibosch Oct 27, 2022
e9394b3
Undo the change to the macro ipFR_TCP_VERSION_NUMBER
Oct 27, 2022
56fb75a
Merge branch 'main' into IPv4_single_comments_after_MISRA
htibosch Oct 27, 2022
4ed9a20
Merge branch 'main' into IPv4_single_comments_after_MISRA
ActoryOu Jul 19, 2023
662462e
Remove redundant variablein DNS_Networking.c.
ActoryOu Jul 19, 2023
de08f15
Formatting.
ActoryOu Jul 19, 2023
312e881
Merge branch 'main' into IPv4_single_comments_after_MISRA
ActoryOu Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions source/FreeRTOS_DNS.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1139,7 +1139,7 @@
BaseType_t xFamily,
const struct freertos_sockaddr * pxAddress )
{
BaseType_t uxReturn = pdFAIL;
BaseType_t xReturn = pdFAIL;
struct xDNSBuffer xDNSBuf = { 0 };
NetworkBufferDescriptor_t * pxNetworkBuffer = NULL;
size_t uxHeaderBytes;
Expand Down Expand Up @@ -1215,17 +1215,17 @@
}

/* send the dns message */
uxReturn = DNS_SendRequest( xDNSSocket,
pxAddress,
&xDNSBuf );
xReturn = DNS_SendRequest( xDNSSocket,
pxAddress,
&xDNSBuf );

if( uxReturn == pdFAIL )
if( xReturn == pdFAIL )
{
vReleaseNetworkBufferAndDescriptor( pxNetworkBuffer );
}
}

return uxReturn;
return xReturn;
}

/*!
Expand All @@ -1251,7 +1251,7 @@
struct freertos_sockaddr xAddress;
struct freertos_sockaddr xRecvAddress;
DNSBuffer_t xReceiveBuffer = { 0 };
BaseType_t uxReturn = pdFAIL;
BaseType_t xReturn = pdFAIL;
BaseType_t xBytes;
NetworkEndPoint_t * pxEndPoint;

Expand Down Expand Up @@ -1290,13 +1290,13 @@
}
}

uxReturn = prvSendBuffer( pcHostName,
uxIdentifier,
xDNSSocket,
xFamily,
&xAddress );
xReturn = prvSendBuffer( pcHostName,
uxIdentifier,
xDNSSocket,
xFamily,
&xAddress );

if( uxReturn == pdFAIL )
if( xReturn == pdFAIL )
{
break;
}
Expand Down