MISRA violation fix 17.7, 1.2, 8.9 #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AniruddhaKanhere
left a comment
AniruddhaKanhere
left a comment
There was a problem hiding this comment.
Thanks for this PR @xuelix.
I have a couple of comments. Can you please take a look?
| prvGetCacheIPEntry( uxIndex, | ||
| pulIP, | ||
| ulCurrentTimeSeconds ); | ||
| ( void ) prvGetCacheIPEntry( uxIndex, |
Member
There was a problem hiding this comment.
Maybe we should add a comment about why the result is being discarded here and why is it safe to do so.
Something along the lines of:
/* This statement can only be reached when xResult is true; which
* implies that the entry is present and a 'get' operation will result
* in success. Therefore, it is safe to ignore the return value of the
* below function. */
Member
Author
There was a problem hiding this comment.
We have too many (void) in front of functions (e.g. hundreds of them including memcpy) . I don't think we need to add for one specific function calls.
n9wxu
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing MISRA violation 17.7, 1.2 and 8.9
Description
Test Steps
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.