Make conversions from uint8 to eIPTCPState_t explicit #445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents this warning from the TI CCS compiler:
warning FreeRTOS#190-D: enumerated type mixed with another type
Regardless of this compiler warning it seems like a good idea to signal
that this conversion is OK and expected. This is already being done when
doing the opposite conversion.
AniruddhaKanhere
approved these changes
Apr 5, 2022
Member
|
Thank you @jonathangjertsen for this PR, I have approved it and working on merging it after another review. |
paulbartell
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents this warning from the TI CCS compiler:
I haven't seen this warning from other compilers, but it seems like a good idea regardless to signal that this conversion is OK and expected. Explicit casts are already being used for the opposite conversion.
This and #444 should be sufficient to compile the library without warnings with TI's compiler, with one exception which I will create an issue for because I don't know the library well enough to resolve it
Test Steps
None
Related Issue
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.