Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
be9fe45
Fix compiler warnings when the TCP Window is not used (#124)
AniruddhaKanhere Dec 18, 2020
a342f50
parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
htibosch Jan 5, 2021
9de49b5
Remove unused file
AniruddhaKanhere Apr 21, 2021
7e84016
Merge pull request #15 from FreeRTOS/main
AniruddhaKanhere Apr 21, 2021
3c4db2d
Fix Some warnings
AniruddhaKanhere Apr 21, 2021
b183908
Merge branch 'main' into fix_warnings
AniruddhaKanhere Apr 21, 2021
d384db0
merge tcp_mem_stats
AniruddhaKanhere Jun 9, 2021
36cc08c
Merge pull request #17 from FreeRTOS/main
AniruddhaKanhere Jun 9, 2021
d43a5fc
Merge pull request #18 from FreeRTOS/main
AniruddhaKanhere Jul 21, 2021
393669b
Merge pull request #22 from FreeRTOS/main
AniruddhaKanhere Sep 10, 2021
9fd9010
Merge pull request #24 from FreeRTOS/main
AniruddhaKanhere Sep 10, 2021
59d63eb
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Sep 17, 2021
7f2ca0a
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Sep 20, 2021
c5b11bc
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Sep 21, 2021
491470f
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Sep 28, 2021
5440582
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Oct 7, 2021
7c1bfd2
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Oct 19, 2021
013f781
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Oct 21, 2021
216552b
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Oct 29, 2021
5e51570
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Nov 23, 2021
ad97450
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere Dec 20, 2021
cae9867
Add automated uncrustify
AniruddhaKanhere Dec 21, 2021
2489819
Merge branch 'main' into AddAutoUncrustify
AniruddhaKanhere Dec 21, 2021
3e3b401
Un-uncrustify
AniruddhaKanhere Dec 21, 2021
2616a3f
Uncrustify - manually
AniruddhaKanhere Dec 21, 2021
c4a2f70
Remove unused comment
AniruddhaKanhere Dec 21, 2021
9936eee
Update user to be github action
AniruddhaKanhere Dec 21, 2021
adf8de2
Remove catch_assert from uncrustify
AniruddhaKanhere Dec 22, 2021
54be5e1
Add comment to let user know on what to do and run uncrustify a secon…
AniruddhaKanhere Dec 22, 2021
f7a6edd
Merge branch 'main' into AddAutoUncrustify
AniruddhaKanhere Dec 22, 2021
c305d1a
Return a failure when uncrustify fails
AniruddhaKanhere Dec 22, 2021
aff183e
Merge branch 'AddAutoUncrustify' of https://github.com/AniruddhaKanhe…
AniruddhaKanhere Dec 22, 2021
2bdd263
Add some more info for the user
AniruddhaKanhere Dec 22, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ jobs:
run: |
uncrustify --version
find . -not -path '.*catch_assert.h' -iname "*.[hc]" -exec uncrustify --check -c tools/uncrustify.cfg {} +
if [ "$?" = "0" ]; then
exit 0
else
echo -e "\033[31;1;43mFormatting check (using Uncrustify) failed...\033[0m"
echo -e "\033[32;3mTo have the code uncrustified for you, please comment '/bot run uncrustify' (without the quotes) on the Pull Request.\033[0m"
exit 1
fi
- name: Check For Trailing Whitespace
run: |
set +e
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/uncrustify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
run: |
uncrustify --version
find . -not -path '.*catch_assert.h' -iname "*.[hc]" -exec uncrustify -c tools/uncrustify.cfg --no-backup --replace {} +
find . -not -path '.*catch_assert.h' -iname "*.[hc]" -exec uncrustify -c tools/uncrustify.cfg --no-backup --replace {} +
Comment on lines 42 to +43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a suggestion for future work...It would be cool to run uncrustify as long as it is modifying files. I'd think this could be done in a loop by simply staging before every uncrustify operation and then after uncrustify-ing checking if any modified files are present.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I am also thinking of just uncrustify-ing the files which were actually changed by the PR. However, these optimizations can be added incrementally.

- name: Push changes to upstream repository
run: |
git config --global user.name 'GitHub Action'
Expand Down