generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 208
Minor changes to the GH action uncrustify #401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
be9fe45
Fix compiler warnings when the TCP Window is not used (#124)
AniruddhaKanhere a342f50
parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
htibosch 9de49b5
Remove unused file
AniruddhaKanhere 7e84016
Merge pull request #15 from FreeRTOS/main
AniruddhaKanhere 3c4db2d
Fix Some warnings
AniruddhaKanhere b183908
Merge branch 'main' into fix_warnings
AniruddhaKanhere d384db0
merge tcp_mem_stats
AniruddhaKanhere 36cc08c
Merge pull request #17 from FreeRTOS/main
AniruddhaKanhere d43a5fc
Merge pull request #18 from FreeRTOS/main
AniruddhaKanhere 393669b
Merge pull request #22 from FreeRTOS/main
AniruddhaKanhere 9fd9010
Merge pull request #24 from FreeRTOS/main
AniruddhaKanhere 59d63eb
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 7f2ca0a
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere c5b11bc
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 491470f
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 5440582
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 7c1bfd2
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 013f781
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 216552b
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere 5e51570
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere ad97450
Merge branch 'FreeRTOS:main' into main
AniruddhaKanhere cae9867
Add automated uncrustify
AniruddhaKanhere 2489819
Merge branch 'main' into AddAutoUncrustify
AniruddhaKanhere 3e3b401
Un-uncrustify
AniruddhaKanhere 2616a3f
Uncrustify - manually
AniruddhaKanhere c4a2f70
Remove unused comment
AniruddhaKanhere 9936eee
Update user to be github action
AniruddhaKanhere adf8de2
Remove catch_assert from uncrustify
AniruddhaKanhere 54be5e1
Add comment to let user know on what to do and run uncrustify a secon…
AniruddhaKanhere f7a6edd
Merge branch 'main' into AddAutoUncrustify
AniruddhaKanhere c305d1a
Return a failure when uncrustify fails
AniruddhaKanhere aff183e
Merge branch 'AddAutoUncrustify' of https://github.com/AniruddhaKanhe…
AniruddhaKanhere 2bdd263
Add some more info for the user
AniruddhaKanhere File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a suggestion for future work...It would be cool to run uncrustify as long as it is modifying files. I'd think this could be done in a loop by simply staging before every uncrustify operation and then after uncrustify-ing checking if any modified files are present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I am also thinking of just uncrustify-ing the files which were actually changed by the PR. However, these optimizations can be added incrementally.