Add Comment triggered uncrustify script #400
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| name: Uncrustify the source code | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
|
|
||
| jobs: | ||
| Uncrustify: | ||
| name: Run_Uncrustify | ||
| if: ${{ github.event.issue.pull_request && github.event.comment.body == '/bot run uncrustify' }} | ||
| runs-on: ubuntu-18.04 | ||
| steps: | ||
| - name: Dump GitHub context | ||
| env: | ||
| GITHUB_CONTEXT: ${{ toJson(github) }} | ||
| run: echo "$GITHUB_CONTEXT" | ||
| - name: get pullrequest url | ||
| run: | | ||
| echo ${{ github.event.issue.pull_request.url }} | ||
| - name: get upstream repo | ||
| id: upstreamrepo | ||
| run: | | ||
| echo "::set-output name=RemoteRepo::$(curl -H "Accept: application/vnd.github.sailor-v-preview+json" --url ${{ github.event.issue.pull_request.url }} | jq '.head.repo.full_name' | sed 's/\"//g')" | ||
| - name: get upstream branch | ||
| id: upstreambranch | ||
| run: | | ||
| echo "::set-output name=branchname::$(curl -H "Accept: application/vnd.github.sailor-v-preview+json" --url ${{ github.event.issue.pull_request.url }} | jq '.head.ref' | sed 's/\"//g')" | ||
| - name: echo upstream repo:branch | ||
| run: | | ||
| echo ${{ steps.upstreamrepo.outputs.RemoteRepo }}:${{ steps.upstreambranch.outputs.branchname }} | ||
| - name: Checkout upstream repo | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| token: ${{ secrets.PAT }} | ||
| repository: ${{ steps.upstreamrepo.outputs.RemoteRepo }} | ||
| ref: ${{ steps.upstreambranch.outputs.branchname }} | ||
| - name: Install Uncrustify | ||
| run: sudo apt-get install uncrustify | ||
|
Contributor
There was a problem hiding this comment. @cobusve mentioned that there have been compatibility issues between different versions of uncrustify and our config. It might be best to pin this to a particular version.
Member
Author
There was a problem hiding this comment. Yes, as I mentioned above, Ubuntu 18.04 comes with a certain version of uncrustify. And that is what is suitable for us. If that changes, we'd need to update this too. |
||
| - name: Run Uncrustify | ||
| run: | | ||
| uncrustify --version | ||
| find . -not -path '.*catch_assert.h' -iname "*.[hc]" -exec uncrustify -c tools/uncrustify.cfg --no-backup --replace {} + | ||
| - name: Push changes to upstream repository | ||
| run: | | ||
| git config --global user.name 'GitHub Action' | ||
| git config --global user.email '[email protected]' | ||
| git add -A | ||
| git commit -m "Uncrustify: triggered by comment." | ||
| git push | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18.04 is getting a bit old. Will this run on ubuntu-latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18.04 comes with a certain version of uncrustify. That is the one we use. That is why we stuck with using Ubuntu 18.04.