IPv6/Multi: Reduced complexity FreeRTOS_TCP_WIN.c #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htibosch
changed the title
AniruddhaKanhere
requested changes
Aug 3, 2021
FreeRTOS_TCP_WIN.c
Outdated
Comment on lines
1440
to
1451
| /* if( ( ipconfigTCP_MAY_LOG_PORT( pxWindow->usOurPortNumber ) ) && */ | ||
| /* ( ( xTCPWindowLoggingLevel >= 3 ) || */ | ||
| /* ( ( xTCPWindowLoggingLevel >= 2 ) && ( pxWindow->pxHeadSegment != NULL ) ) ) ) */ | ||
| /* { */ | ||
| /* FreeRTOS_debug_printf( ( "lTCPWindowTxAdd: New %4ld bytes for seqNr %lu len %4lu (nxt %lu) pos %lu\n", */ | ||
| /* ulLength, */ | ||
| /* pxSegment->ulSequenceNumber - pxWindow->tx.ulFirstSequenceNumber, */ | ||
| /* pxSegment->lDataLength, */ | ||
| /* pxWindow->ulNextTxSequenceNumber - pxWindow->tx.ulFirstSequenceNumber, */ | ||
| /* pxSegment->lStreamPos ) ); */ | ||
| /* FreeRTOS_flush_logging(); */ | ||
| /* } */ |
Contributor
Author
There was a problem hiding this comment.
I disabled the comment with double slashes, uncrustify replaced them by proper C comments /* */.
This is a very old logging statement, which increases the complexity of the function from 6 to 14.
As I haven't enabled any TCP_WIN logging for many years, I will take it away.
FreeRTOS_TCP_WIN.c
Outdated
| /* This out-of-sequence packet has been received for a | ||
| * second time. It is already stored but do send a SACK | ||
| * again. */ | ||
| /* A negative value will be returned to indicate than error. */ |
Member
There was a problem hiding this comment.
Suggested change
| /* A negative value will be returned to indicate than error. */ | |
| /* A negative value will be returned to indicate an error. */ |
AniruddhaKanhere
approved these changes
Aug 5, 2021
dan4thewin
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The module FreeRTOS+TCP_WIN.c had 4 functions with a high score on complexity. I cut down their size by moving some code the helper functions:
lTCPWindowRxCheck() score 66
lTCPWindowTxAdd() score 35
ulTCPWindowTxGet() score 43
prvTCPWindowTxCheckAck() score 25
Test Steps
I tested by transferring files in both directions while dropping random packets in both directions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.