IPv6/Multi: Let IP-task use vSocketCloseNextTime instead of FreeRTOS_closesocket #276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the same in the IPv6/multi branch as PR #238 did for the IPv4 branch.
Background: the function
FreeRTOS_closesocket()can fail if the queue to the IP-task is full. A normal task can wait for space, but the IP-task would create a dead-lock by waiting for itself.This PR has a safe alternative for
FreeRTOS_closesocket()that can only be used by the IP-task.Test Steps
I tested this PR by corrupting the TCP flags of an incoming packet during the SYN phase around here. That leads to an immediate closure of the socket like this:
Related Issue
It is recommended to make the message queue big enough so that it never gets full. Just like a stack should never overflow.
The queue length is defined as
ipconfigEVENT_QUEUE_LENGTH. I often define it as:See also
uxGetMinimumIPQueueSpace(), which is defined whenipconfigCHECK_IP_QUEUE_SPACE=1. It can be used to monitor the queue size.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.