Use a define for ETHER_CHANNEL_0 in RX/NetworkInterfac.c #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other driver calls use ETHER_CHANNEL_0 just this one did pass 0, but this param is in fact the channel number.
htibosch
approved these changes
Jul 8, 2021
Contributor
htibosch
left a comment
htibosch
left a comment
There was a problem hiding this comment.
Bernd, thank you for this change.
| else if( ( xTaskCheckForTimeOut( &xPhyTime, &xPhyRemTime ) != pdFALSE ) || ( FreeRTOS_IsNetworkUp() == pdFALSE ) ) | ||
| { | ||
| R_ETHER_LinkProcess( 0 ); | ||
| R_ETHER_LinkProcess( ETHER_CHANNEL_0 ); |
Contributor
There was a problem hiding this comment.
As the parameter is documented as "ETHERC channel number", it sounds like a good change.
AniruddhaKanhere
approved these changes
Jul 9, 2021
gkwicker
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other driver calls use ETHER_CHANNEL_0 just this one
did pass 0, but this param is in fact the channel number.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.