Skip to content

Fix misc warnings. #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2021
Merged

Fix misc warnings. #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be9fe45
Fix compiler warnings when the TCP Window is not used (#124)
AniruddhaKanhere Dec 18, 2020
a342f50
parent be9fe45d8ec440f7750de0f4870b28de39b10a3b
htibosch Jan 5, 2021
9de49b5
Remove unused file
AniruddhaKanhere Apr 21, 2021
7e84016
Merge pull request #15 from FreeRTOS/main
AniruddhaKanhere Apr 21, 2021
3c4db2d
Fix Some warnings
AniruddhaKanhere Apr 21, 2021
b183908
Merge branch 'main' into fix_warnings
AniruddhaKanhere Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions FreeRTOS_IP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1997,13 +1997,11 @@ static eFrameProcessingResult_t prvAllowIPPacket( const IPPacket_t * const pxIPP
if( pxIPPacket->xIPHeader.ucProtocol == ( uint8_t ) ipPROTOCOL_UDP )
{
ProtocolPacket_t * pxProtPack;
const uint16_t * pusChecksum;

/* pxProtPack will point to the offset were the protocols begin. */
pxProtPack = ipCAST_PTR_TO_TYPE_PTR( ProtocolPacket_t, &( pxNetworkBuffer->pucEthernetBuffer[ uxHeaderLength - ipSIZE_OF_IPv4_HEADER ] ) );
pusChecksum = ( const uint16_t * ) ( &( pxProtPack->xUDPPacket.xUDPHeader.usChecksum ) );

if( *pusChecksum == ( uint16_t ) 0U )
if( pxProtPack->xUDPPacket.xUDPHeader.usChecksum == ( uint16_t ) 0U )
Copy link
Contributor

@htibosch htibosch Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a welcome change, because usChecksum is a member of a packed struct.

{
#if ( ipconfigHAS_PRINTF != 0 )
{
Expand Down
2 changes: 1 addition & 1 deletion tools/tcp_utilities/tcp_mem_stats.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

#ifndef ipconfigTCP_MEM_STATS_MAX_ALLOCATION
#define ipconfigTCP_MEM_STATS_MAX_ALLOCATION 128u
#pragma warning "ipconfigTCP_MEM_STATS_MAX_ALLOCATION undefined?"
#pragma message ("ipconfigTCP_MEM_STATS_MAX_ALLOCATION undefined?")
Copy link
Contributor

@htibosch htibosch Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is nice, this works for both Visual Studio and for GCC.

#endif

#if ( ipconfigUSE_TCP_MEM_STATS != 0 )
Expand Down