Skip to content

fix compiler warnings about casting to format string #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 2, 2021
Merged

fix compiler warnings about casting to format string #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
823ee15
fix compiler warnings about casting to format string
twpedersen Feb 20, 2021
46e6df8
explicitly cast arguments to format string
twpedersen Feb 22, 2021
b425e46
Merge branch 'main' into twp/tcp_warn
AniruddhaKanhere Mar 2, 2021
eac3398
Uncrustify
AniruddhaKanhere Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FreeRTOS_IP.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3398,7 +3398,7 @@ const char * FreeRTOS_strerror_r( BaseType_t xErrnum,

default:
/* Using function "snprintf". */
( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int32_t ) xErrnum );
( void ) snprintf( pcBuffer, uxLength, "Errno %d", ( int ) xErrnum );
pcName = NULL;
break;
}
Expand Down
14 changes: 7 additions & 7 deletions FreeRTOS_Sockets.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3977,13 +3977,13 @@ void vSocketWakeUpUser( FreeRTOS_Socket_t * pxSocket )
if( xResult != ( int32_t ) ulByteCount )
{
FreeRTOS_debug_printf( ( "lTCPAddRxdata: at %u: %d/%u bytes (tail %u head %u space %u front %u)\n",
( UBaseType_t ) uxOffset,
( BaseType_t ) xResult,
( UBaseType_t ) ulByteCount,
( UBaseType_t ) pxStream->uxTail,
( UBaseType_t ) pxStream->uxHead,
( UBaseType_t ) uxStreamBufferFrontSpace( pxStream ),
( UBaseType_t ) pxStream->uxFront ) );
( unsigned int ) uxOffset,
( int ) xResult,
( unsigned int ) ulByteCount,
( unsigned int ) pxStream->uxTail,
( unsigned int ) pxStream->uxHead,
( unsigned int ) uxStreamBufferFrontSpace( pxStream ),
( unsigned int ) pxStream->uxFront ) );
}
}
#endif /* ipconfigHAS_DEBUG_PRINTF */
Expand Down
6 changes: 3 additions & 3 deletions FreeRTOS_TCP_WIN.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,9 +1183,9 @@
FreeRTOS_debug_printf( ( "lTCPWindowRxCheck[%d,%d]: seqnr %u exp %u (dist %d) SACK to %u\n",
( int ) pxWindow->usPeerPortNumber,
( int ) pxWindow->usOurPortNumber,
Copy link
Contributor

@htibosch htibosch Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cast from short or char to int would not be necessary as the compiler will up-cast them automatically when ellipsis are used.

( unsigned ) ulSequenceNumber - pxWindow->rx.ulFirstSequenceNumber,
( unsigned ) ulCurrentSequenceNumber - pxWindow->rx.ulFirstSequenceNumber,
( unsigned ) ( ulSequenceNumber - ulCurrentSequenceNumber ), /* want this signed */
( unsigned ) ( ulSequenceNumber - pxWindow->rx.ulFirstSequenceNumber ),
( unsigned ) ( ulCurrentSequenceNumber - pxWindow->rx.ulFirstSequenceNumber ),
( int ) ( ulSequenceNumber - ulCurrentSequenceNumber ),
( unsigned ) ( ulLast - pxWindow->rx.ulFirstSequenceNumber ) ) );
}

Expand Down