Fix declarations after statements #1106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/bot run formatting |
tony-josi-aws
force-pushed
the
fix_declarations_after_statement
branch
from
e19842b to
cce51c6
Compare
moninom1
reviewed
Feb 23, 2024
shubnil
reviewed
Feb 23, 2024
Contributor
shubnil
left a comment
shubnil
left a comment
There was a problem hiding this comment.
The change looks good.
But, I have 2 queries.
- Is declaration at the top enough for C90 or should we initialize to some default values as well
- Are we just moving the declaration up and initialization is still at its place
Member
Author
|
shubnil
approved these changes
Feb 23, 2024
kar-rahul-aws
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the codebase to remove declarations after statements that are non compliant as per the C90 standard.
Test Steps
Checklist:
[ ] I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.