Skip to content

Fix assertion failure when disconnecting the Ethernet cable (NXP1060 - NetworkInterface.c) #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Fix assertion failure when disconnecting the Ethernet cable (NXP1060 - NetworkInterface.c) #1002

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bceca7e
Update NetworkInterface.c
microcris Aug 10, 2023
6d2ab53
Update NetworkInterface.c
microcris Aug 10, 2023
2eadf5c
Update NetworkInterface.c
microcris Aug 10, 2023
43bdb48
Update NetworkInterface.c
microcris Aug 10, 2023
7621b80
Update NetworkInterface.c
microcris Aug 10, 2023
504a1f2
Merge branch 'main' into microcris-patch-1
microcris Aug 10, 2023
098837f
Merge branch 'main' into microcris-patch-1
microcris Aug 12, 2023
a23c1ad
Update source/portable/NetworkInterface/NXP1060/NetworkInterface.c
microcris Aug 16, 2023
8e76a73
Update source/portable/NetworkInterface/NXP1060/NetworkInterface.c
microcris Aug 17, 2023
9be9cf8
Merge branch 'main' into microcris-patch-1
ActoryOu Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions source/portable/NetworkInterface/NXP1060/NetworkInterface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,6 +347,11 @@ static BaseType_t prvNXP1060_NetworkInterfaceInitialise( NetworkInterface_t * px

if( xStatus != kStatus_Success )
{
if( !xFirstCall )
{
xTaskNotify( receiveTaskHandle, DRIVER_READY, eSetValueWithOverwrite );
}

break;
}
else
Expand All @@ -370,7 +375,7 @@ static BaseType_t prvNXP1060_NetworkInterfaceInitialise( NetworkInterface_t * px
xTaskCreated = xTaskCreate( prvEMACHandlerTask,
"EMAC-Handler",
configMINIMAL_STACK_SIZE * 3,
NULL,
pxInterface,
configMAX_PRIORITIES - 1,
&receiveTaskHandle );

Expand Down Expand Up @@ -505,7 +510,7 @@ static void prvEMACHandlerTask( void * parameter )
if( ulTaskNotifyTake( pdTRUE, pdMS_TO_TICKS( 500 ) ) == pdFALSE )
{
/* No RX packets for a bit so check for a link. */
const IPStackEvent_t xNetworkEventDown = { .eEventType = eNetworkDownEvent, .pvData = NULL };
const IPStackEvent_t xNetworkEventDown = { .eEventType = eNetworkDownEvent, .pvData = parameter };

do
{
Expand Down Expand Up @@ -568,13 +573,13 @@ static void prvEMACHandlerTask( void * parameter )
break;

case kStatus_ENET_RxFrameError: /* Received an error frame. Read & drop it */
PRINTF( "RX Receive Error\n" );
FreeRTOS_printf( ( "RX Receive Error\n" ) );
ENET_ReadFrame( ethernetifLocal->base, &( ethernetifLocal->handle ), NULL, 0, 0, NULL );
/* Not sure if a trace is required. The MAC had an error and needed to dump bytes */
break;

default:
PRINTF( "RX Receive default" );
FreeRTOS_printf( ( "RX Receive default" ) );
break;
}
}
Expand Down