[BUG] Usage of uint64_t is against C90 standard

[go2sh]

Describe the bug
long long and unsigned long long aka uint64_t are not part of the C90 standard. The tasking compiler will not compile the code when C90 is set as standard.

Target

• Toolchain and version: Tasking Tricore Compiler 6.4r1p6

Host

• Host OS: Windows
• Version: 10

To Reproduce

• Compile FreeRTOS-Plus-TCP with Tasking compiler

Expected behavior
Should compile

To use uint64_t standard conform the c standard has to increase to C99.

[gmtt]

Thanks for bringing up this issue, regarding the Coding Standard on this page:

FreeRTOS builds with many different compilers, some of which are more advanced than others. For that reason FreeRTOS does not use any of the features or syntax that have been introduced to the C language by, or since, the C99 standard. The one exception to this is the use of the stdint.h header file. The FreeRTOS/Source/include directory contains a file called stdint.readme that can be renamed stdint.h to provide the minimum stdint type definitions necessary to build FreeRTOS - should your compiler not provide its own.

For most cases, we follow C90 standard, but we do have exception for stdint.h header file. Please follow the instruction above to introduce uint64_t into your code.

If you still face problems, please let us know.

[go2sh]

uint64_t is not part of the file you mentioned. The main problem with the tasking compiler is that long long and unsigned long long types, which are 64 bit in the target abi, are not available in C90 mode of the compiler. The reason is that the long long types were introduced in C99. The solution is easy for me, change the compile standard to C99 in the cmake target and the compilation works fine including the compiler provided uint64_t type.

I just wanted to point out, that a strict C90 compiler might not be able to compile the code. And the default CMake file set the standard to C90.

[htibosch]

@go2sh, can you please show which code lines use uint64_t is used?

[go2sh]

It's in FreeRTOS_IP_Private.h#L541 and
FreeRTOS_IP_Private.h#L728.

[htibosch]

Ah yes, I thought so. I think that it wouldn't hurt anyone to remove those declarations.

[moninom1]

@go2sh
#907 Added fix for the Bug. Thank you for reporting it.

[moninom1]

@go2sh Once again thank you for reporting the bug.
Closing as the bug as the fix got merged. Feel free to reopen the issue if some other information is needed.

Thanks