Possible overflow in xProcessReceivedTCPPacket

[bernd-edlinger]

This check looks as if has an issue if ulCurrentSequenceNumber + ulRxWindowLength overflows:

FreeRTOS-Plus-TCP/FreeRTOS_TCP_IP.c

Lines 3586 to 3588 in d6ed447

	else if( ( ulSequenceNumber > pxSocket->u.xTCP.xTCPWindow.rx.ulCurrentSequenceNumber ) &&
	( ulSequenceNumber < ( pxSocket->u.xTCP.xTCPWindow.rx.ulCurrentSequenceNumber +
	pxSocket->u.xTCP.xTCPWindow.xSize.ulRxWindowLength ) ) )

[AniruddhaKanhere]

Hello @bernd-edlinger, thanks for bringing this to our notice. We'll look into this and report back shortly.

[htibosch]

I just prepared a PR #225 with the title "Before sending a challenge ACK, check the sequence number more properly".
It is using the sequence number routines that are defined in FreeRTOS_TCP_WIN.c.

@bernd-edlinger, : thanks a lot for reporting this. You can not close this issue.

[bernd-edlinger]

Fixed with commit e88ecd3.
Thanks!