Skip to content

Conversation

kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented Feb 13, 2024

Description

xPortIsAuthorizedToAccessBuffer() API is used only in the latest version of secure MPU wrappers ( V10.6.x ) , and not in the older wrapper versions. xSchedulerRunning variable is defined only in the latest version, hence when trying to compile the API with the old wrapper leads to compilation error. Hence , this PR adds the requirement of setting configUSE_MPU_WRAPPERS_V1 = 0 , to enable application writers to use this API.

Test Steps

MPU soak test on STM32H743ZI

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner February 13, 2024 20:06
@kar-rahul-aws kar-rahul-aws marked this pull request as draft February 13, 2024 20:11
@kar-rahul-aws kar-rahul-aws changed the title Allow xPortIsAuthorizedToAccessBuffer() API call from secure MPU wrapper Allow xPortIsAuthorizedToAccessBuffer() API call only from secure MPU wrapper Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (a455b86) to head (845134a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #992   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files           6        6           
  Lines        3200     3200           
  Branches      879      879           
=======================================
  Hits         2976     2976           
  Misses        111      111           
  Partials      113      113           
Flag Coverage Δ
unittests 93.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kar-rahul-aws kar-rahul-aws marked this pull request as ready for review February 13, 2024 20:26
@kar-rahul-aws kar-rahul-aws changed the title Allow xPortIsAuthorizedToAccessBuffer() API call only from secure MPU wrapper Allow xPortIsAuthorizedToAccessBuffer() API call only from mpu_wrappers_v2 Mar 12, 2024
Skptak
Skptak previously approved these changes Mar 27, 2024
Signed-off-by: Gaurav Aggarwal <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kar-rahul-aws kar-rahul-aws merged commit 39dbff7 into FreeRTOS:main Mar 27, 2024
@kar-rahul-aws kar-rahul-aws deleted the update_MPU_ports branch March 27, 2024 08:35
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
* Add reg tests to NuMaker M2351 project

Signed-off-by: Gaurav Aggarwal <[email protected]>

* Add reg tests for IAR

Signed-off-by: Gaurav Aggarwal <[email protected]>

* Fix formatting check

Signed-off-by: Gaurav Aggarwal <[email protected]>

* Fix header check

Signed-off-by: Gaurav Aggarwal <[email protected]>

---------

Signed-off-by: Gaurav Aggarwal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants