Skip to content

Conversation

ericbj29
Copy link
Contributor

@ericbj29 ericbj29 commented Feb 4, 2024

Correct ARM port folder capitalization

Description

Other ARM ports are prefixed "ARM" rather than "Arm." Correcting these ports (ARM_AARCH64 and ARM_AARCH64_SRE) for consistency.

Test Steps

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ericbj29 ericbj29 requested a review from a team as a code owner February 4, 2024 04:51
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c19b13c) 93.62% compared to head (6668dff) 93.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files           6        6           
  Lines        3199     3199           
  Branches      886      886           
=======================================
  Hits         2995     2995           
  Misses         92       92           
  Partials      112      112           
Flag Coverage Δ
unittests 93.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aggarg
aggarg previously approved these changes Feb 5, 2024
* Update in portable/CmakeLists.txt
* Use capitalization name in port README.md
Copy link
Contributor

@chinglee-iot chinglee-iot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help to take a look at this PR and adapt the change for the following fixes:

  • Update in portable/CmakeLists.txt
  • Use capitalization name in port README.md

Update cmake for ARM port folder capitalization
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@paulbartell
Copy link
Contributor

Not a big fan of renaming directories like this since it's likely to cause build failures for users on case-sensitive filesystems.

@ericbj29 ericbj29 merged commit 938ec0f into FreeRTOS:main Feb 5, 2024
laroche pushed a commit to laroche/FreeRTOS-Kernel that referenced this pull request Apr 18, 2024
MinghuanLian pushed a commit to nxp-mcuxpresso/FreeRTOS-Kernel that referenced this pull request Nov 28, 2024
* Rename Arm_AARCH64 to ARM_AARCH64

* Rename Arm_AARCH64_SRE to ARM_AARCH64_SRE

* Update cmake for ARM port folder capitalization

* Update in portable/CmakeLists.txt
* Use capitalization name in port README.md

---------

Co-authored-by: Ching-Hsin Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants