-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Correct ARM port folder capitalization #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 6 6
Lines 3199 3199
Branches 886 886
=======================================
Hits 2995 2995
Misses 92 92
Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Update in portable/CmakeLists.txt * Use capitalization name in port README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help to take a look at this PR and adapt the change for the following fixes:
- Update in portable/CmakeLists.txt
- Use capitalization name in port README.md
Update cmake for ARM port folder capitalization
|
Not a big fan of renaming directories like this since it's likely to cause build failures for users on case-sensitive filesystems. |
Signed-off-by: Gaurav Aggarwal <[email protected]>
* Rename Arm_AARCH64 to ARM_AARCH64 * Rename Arm_AARCH64_SRE to ARM_AARCH64_SRE * Update cmake for ARM port folder capitalization * Update in portable/CmakeLists.txt * Use capitalization name in port README.md --------- Co-authored-by: Ching-Hsin Lee <[email protected]>
Correct ARM port folder capitalization
Description
Other ARM ports are prefixed "ARM" rather than "Arm." Correcting these ports (
ARM_AARCH64
andARM_AARCH64_SRE
) for consistency.Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.