Skip to content

Conversation

@hathach
Copy link
Contributor

@hathach hathach commented Nov 16, 2023

Description

Fix missing semicolon in portEND_SWITCHING_ISR() in IAR/CM0/portmacro.h

Test Steps

Found when running ci on my repo https://github.com/hathach/tinyusb/actions/runs/6892688960/job/18750555563?pr=2320#step:5:7399

Error[Pe065]: 
          expected a ";"

      portYIELD_FROM_ISR(xHigherPriorityTaskWoken);

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

  • n/a

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@hathach hathach requested a review from a team as a code owner November 16, 2023 16:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc09a3d) 93.51% compared to head (e87f218) 93.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
+ Coverage   93.51%   93.67%   +0.15%     
==========================================
  Files           6        6              
  Lines        3177     3177              
  Branches      884      884              
==========================================
+ Hits         2971     2976       +5     
+ Misses         99       94       -5     
  Partials      107      107              
Flag Coverage Δ
unittests 93.67% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moninom1 moninom1 changed the title fix IAR/CM0/portmacro.h missing semicolon Fix IAR/CM0/portmacro.h missing semicolon Nov 18, 2023
@aggarg aggarg merged commit 4ff01a7 into FreeRTOS:main Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants