Skip to content

Conversation

@kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented Oct 19, 2023

Fix MISRA C 2012 rule 20.7 violation

Description

MISRA C 2012 rule 20.7

Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses.

MISRA C Violation

The macro definition is MISRA noncompliant if it fails to parenthesize the parameters and the expressions resulting from the expansion improperly, since the results may be not the one expected.
The macro definition:

    #define prvSEND_COMPLETED( pxStreamBuffer )                                               \
    do {                                                                                      \
        if( ( pxStreamBuffer )->pxSendCompletedCallback != NULL )                             \
        {                                                                                     \
            pxStreamBuffer->pxSendCompletedCallback( ( pxStreamBuffer ), pdFALSE, NULL ); \
        }                                                                                     \
        else                                                                                  \
        {                                                                                     \
            sbSEND_COMPLETED( ( pxStreamBuffer ) );                                           \
        }                                                                                     \
    } while( 0 )

Fix
In this macro defintion, pxStreamBuffer should be parenthesized appropriately.

Test Steps

N/A

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84c0047) 93.77% compared to head (907e168) 93.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files           6        6           
  Lines        3179     3179           
  Branches      885      885           
=======================================
  Hits         2981     2981           
  Misses         91       91           
  Partials      107      107           
Flag Coverage Δ
unittests 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Skptak
Skptak previously approved these changes Oct 19, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@chinglee-iot chinglee-iot merged commit edce1e9 into FreeRTOS:main Dec 6, 2023
@kar-rahul-aws kar-rahul-aws deleted the fix_misra_20_7 branch February 1, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants