Skip to content

Conversation

@chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Sep 6, 2023

Description

Add taskYIELD_WITHIN_API macro to align single core and SMP FreeRTOS in the following files

  • event_groups.c
  • tasks.c
  • queue.c
  • timer.c

Test Steps

N/A

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

Address #750 comment in line 2100

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

* Add taskTASK_IS_RUNNING_OR_YIELDING macro to align single core and SMP
* Add yield within API macro for readibility
@chinglee-iot chinglee-iot requested a review from a team as a code owner September 6, 2023 02:18
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5cdb1bc) 93.62% compared to head (1cece70) 93.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files           6        6           
  Lines        2508     2508           
  Branches      598      598           
=======================================
  Hits         2348     2348           
  Misses        107      107           
  Partials       53       53           
Flag Coverage Δ
unittests 93.62% <81.81%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
queue.c 91.91% <100.00%> (ø)
tasks.c 94.81% <100.00%> (ø)
timers.c 98.77% <100.00%> (ø)
event_groups.c 82.23% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chinglee-iot
Copy link
Member Author

This PR only update for readability. The coverage rate is not changed in this PR.

ActoryOu
ActoryOu previously approved these changes Sep 6, 2023
@chinglee-iot chinglee-iot changed the title Add YIELD_WITHIN_API macros Add taskYIELD_WITHIN_API macro Sep 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aggarg aggarg merged commit 830533d into FreeRTOS:main Oct 4, 2023
@aggarg aggarg deleted the add-yield-within-api-macro branch October 4, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants