event-groups: Fix multiple definitions #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aggarg
reviewed
Aug 14, 2025
This commit does the following: * Remove xEventGroupClearBitsFromISR and xEventGroupSetBitsFromISR functions direct mapping to xTimerPendFunctionCallFromISR in case the trace facility is feature not set. This should match the current implementation in which the application calling xEventGroupClearBitsFromISR without defining the trace macros (i.e. traceENTER_xEventGroupClearBitsFromISR is a blank function in this case) will end up calling xTimerPendFunctionCallFromISR function directly. This enhances the readability of the code by not guarding the xEventGroup<Set/Clear>BitsFromISR functions' declaration and definition based on the trace facility macro (i.e. configUSE_TRACE_FACILITY). * Refactor the guarding macros for MPU_xEventGroupClearBitsFromISR and MPU_xEventGroupSetBitsFromISR functions to match the change above. The current implementation leads to redefinition warnings as `event_groups.h`redefines xEventGroupClearBitsFromISR and xEventGroupSetBitsFromISR based on `configUSE_TRACE_FACILITY' after they have been defined based on configUSE_MPU_WRAPPERS_V1 in `mpu_wrappers.h`. The implemented changes should resolve these warnings. Signed-off-by: Ahmed Ismail <[email protected]>
AhmedIsmail02
force-pushed
the
fix-multiple-definitions-of-xEventGroupSet/ClearBitsFromISR
branch
from
c722e74 to
8cdf4e9
Compare
|
aggarg
approved these changes
Aug 14, 2025
kstribrnAmzn
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does the following:
Remove
xEventGroupClearBitsFromISRandxEventGroupSetBitsFromISRfunctions direct mapping toxTimerPendFunctionCallFromISRin case the trace facility is feature not set. This should match the current implementation in which the application callingxEventGroupClearBitsFromISRwithout defining the trace macros (i.e.traceENTER_xEventGroupClearBitsFromISRis a blank function in this case) will end up callingxTimerPendFunctionCallFromISRfunction directly. This enhances the readability of the code by not guarding thexEventGroup<Set/Clear>BitsFromISRfunctions' declaration and definition based on the trace facility macro (i.e.configUSE_TRACE_FACILITY).Refactor the guarding macros for
MPU_xEventGroupClearBitsFromISRandMPU_xEventGroupSetBitsFromISRfunctions to match the change above.The current implementation leads to redefinition warnings as
event_groups.hredefinesxEventGroupClearBitsFromISRandxEventGroupSetBitsFromISRbased onconfigUSE_TRACE_FACILITYafter they have been defined based onconfigUSE_MPU_WRAPPERS_V1inmpu_wrappers.h. The implemented changes should resolve these warnings.Test Steps
Checklist:
Related Issue
This PR should address the FreeRTOS-Kernel-Bug!1296.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.