Skip to content

Conversation

@chinglee-iot
Copy link
Member

@chinglee-iot chinglee-iot commented Dec 26, 2023

Set to numeric format in atcmdUpdateMccMnc

Description

  • In order not to rely on port initialization. Set to numeric format to acquire MCC and MNC information in atcmdUpdateMccMnc.

Test Steps

Remove the port initialize AT command "AT+COPS=3,2". The MCC and MNC can't be acquired with Cellular_CommonGetRegisteredNetwork correctly.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@ActoryOu ActoryOu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor question. Could you help to elaborate what happens in what platform if we don't limit it to numeric format?

@chinglee-iot chinglee-iot merged commit 9b939eb into FreeRTOS:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants