Link Verifier Changes #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2023
| exclude-urls: https://dummy-url.com/ota.bin, https://dummy-url.com/ota.com, https://dummy-url-three.com/ota.bin, https://github.com/FreeRTOS/A-Repo-That-Wins-You-The-Lottery | ||
|
|
||
| - env: | ||
| stepName: "Functional | Failure | Link Does Not Exist" |
Member
There was a problem hiding this comment.
Is this test not just a subset of Functional | Success | Link Verifier Works & Excludes Directory? Looks like both are checking the same badUrls.md file
2 tasks
rawalexe
approved these changes
Sep 5, 2023
rawalexe
approved these changes
Sep 5, 2023
rawalexe
previously approved these changes
Sep 5, 2023
A-Zaba
approved these changes
Sep 5, 2023
bradleysmith23
approved these changes
Sep 5, 2023
rawalexe
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the link verifier to include a "exclude-urls" option, tests for it, and only print the links that don't work now.