Skip to content

Conversation

@rilakumma
Copy link

closes #171
closes #166

@rilakumma rilakumma requested a review from gksander February 15, 2023 00:23
Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you find any good way to test out these changes? (Doesn't look like we have much of a test-suite, so I'm not sure if there's a specific/easy way to test these things out, other than just installing it in a react app and trying them?)

@stellenberger
Copy link

Is there any chance we can include Ruby as well?

@rilakumma
Copy link
Author

rilakumma commented Feb 17, 2023

@gksander yeah i did test it out on the demo app with this branch and was able to see rust and html styling,
Screen Shot 2023-02-17 at 2 44 38 PM
also, i think that for html we already had that set up as markup so we dont need to add the html alias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Rust language support Type '"html"' is not assignable to type 'Language'

5 participants