-
Notifications
You must be signed in to change notification settings - Fork 3
chore: init-nix #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: init-nix #426
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
View your CI Pipeline Execution ↗ for commit 5bbc2f7
☁️ Nx Cloud last updated this comment at |
Deployed 0cc8213 to https://ForgeRock.github.io/ping-javascript-sdk/pr-426/0cc821329ff4be6a3592e85dcad0429090190cff branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.0 KB, -100.0%) 📊 Minor Changes📈 @forgerock/journey-client - 82.0 KB (+0.0 KB) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.75%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
=======================================
Coverage 18.75% 18.75%
=======================================
Files 138 138
Lines 27368 27368
Branches 951 951
=======================================
Hits 5132 5132
Misses 22236 22236 🚀 New features to boost your workflow:
|
b6c9510
to
8fe98f5
Compare
@forgerock/davinci-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
0f41a57
to
6eb6d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems simple enough. I'm assuming we'll have to manually install Nix on our system. Is that a fairly easy process, much like Homebrew?
Yup, just install nix. i'd reccomend setting up direnv also which takes ~1 minute so when you cd into the directory it autostarts the environment, but again not required, you don't have to use nix. its just an option. |
JIRA Ticket
N/A
Description
This is an interesting concept. Granted we probably don't need it. but I trialied it here for now.
This type of setup probably could happen in the sdk-samples because it is language agnostic but also probably interesting in other parts of the company.
This has 0 effect on any day to day operations as they are now.
You can setup nix locally &
cachix
and then have a 1:1 reproducible setup between ci and your local env.if you setup direnv, it will automatically spawn the nix env and you won't need to do anything otherwise
nix develop
will start the shell, and load everything needed to run the sdk, node, pnpm. you can call all your normal commands in the terminal.cachix caches every nix step. because nix steps are fully reproducible, this also carries to ci, that every step is cached / reproducible.
for now, it seems cachix is free because we are OSS.