-
Notifications
You must be signed in to change notification settings - Fork 3
chore(deps): lock file maintenance #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit 1f08226
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 56.19% 56.19%
=======================================
Files 32 32
Lines 2091 2091
Branches 353 353
=======================================
Hits 1175 1175
Misses 916 916 🚀 New features to boost your workflow:
|
Deployed 191d579 to https://ForgeRock.github.io/ping-javascript-sdk/pr-410/191d5791e861287b83998b8731ad56e5b62d2a5d branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/davinci-client - 34.5 KB (new) 11 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
1115fbf
to
216c654
Compare
216c654
to
99da54b
Compare
99da54b
to
8f0e3fc
Compare
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
0671c98
to
4be59d3
Compare
ca4b9c2
to
c593b4e
Compare
c3be3a6
to
b48c05a
Compare
b48c05a
to
ba0890e
Compare
ba0890e
to
ef473c9
Compare
ef473c9
to
9a8e213
Compare
9a8e213
to
8537ae6
Compare
8537ae6
to
1f08226
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The pull request is a dependency lock file maintenance update (pnpm-lock.yaml) performed by Renovate bot. No application code, test code, or configuration files were modified.
The failing tests are end-to-end Playwright tests for PingOne Protect functionality that verify:
- Risk data collection through the Protect SDK (riskSDK/deviceRisk fields)
- Integration with the PingOne Risk service for evaluating authentication attempts
- Display of blocking messages when the Risk service determines the login should be blocked
Both failing tests follow the same pattern:
- Navigate to a flow with a specific DaVinci configuration
- Fill in username and password
- Submit the form
- Expect to see a blocking message from PingOne Risk
- Verify that Protect data was included in the request
The tests are failing at the assertion that checks for the blocking message visibility. Since no code changes occurred in this PR, the failure indicates the external PingOne Risk service is not returning the expected blocking decision for the test credentials within the 5-second timeout.
This is characteristic of a flaky test that depends on external service behavior rather than a code issue. The Risk service may be experiencing intermittent issues, configuration changes, or the test environment's network conditions may be affecting the timing of the risk evaluation response.
No code fix is appropriate here. The recommended actions would be:
- Verify PingOne Risk service status and configuration
- Consider increasing test timeouts for external service dependencies
- Implement retry logic for tests that depend on external risk evaluation
- Review test data to ensure credentials are properly configured to trigger blocking in the Risk service
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.