-
Notifications
You must be signed in to change notification settings - Fork 3
chore(deps): update dependency immer to v10.1.3 #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
View your CI Pipeline Execution ↗ for commit 4cba9ac
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.75%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #403 +/- ##
=======================================
Coverage 18.75% 18.75%
=======================================
Files 138 138
Lines 27368 27368
Branches 951 951
=======================================
Hits 5132 5132
Misses 22236 22236 🚀 New features to boost your workflow:
|
Deployed a213407 to https://ForgeRock.github.io/ping-javascript-sdk/pr-403/a2134073b9ade045482b9eb13ca9472bf0ed5442 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/device-client - 9.2 KB (new) 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
7a340f3
to
61a19a2
Compare
61a19a2
to
912c4c6
Compare
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
a61f4f4
to
e4e7da5
Compare
e4e7da5
to
6cac4e3
Compare
6cac4e3
to
cda67d6
Compare
cda67d6
to
d761826
Compare
d761826
to
6a3fd58
Compare
6a3fd58
to
ecb5495
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The analysis reveals this is a flaky test issue unrelated to the dependency update:
Why this is classified as 'flaky_task':
The PR only updates immer
from v10.1.1 to v10.1.3 (a patch version bump) and related transitive dependencies in the lockfile. The immer
library is used by @reduxjs/toolkit
for immutable state management in the davinci-client
package. A patch-level update to this dependency would not affect:
- The rendering logic in
/home/workflows/workspace/e2e/davinci-app/main.ts
that displays error messages - The DaVinci API's response status (error vs continue)
- The PingOne Risk evaluation service's behavior
- The DOM manipulation or Playwright's ability to locate elements
Root cause of the test failure:
The tests expect the DaVinci backend to detect bot behavior and return status === 'error'
, which would trigger the renderError()
function to display the blocking message. However, the application is receiving status === 'continue'
instead, so the error rendering path is never executed.
This indicates the failure is due to:
- Backend service behavior (PingOne Risk not flagging the test as a bot)
- Test environment state (geolocation, user agent, or protect SDK data not triggering risk detection)
- External service availability or configuration issues
The protect.test.ts uses a 'fakeprofile' for the Protect SDK collector, which may not reliably trigger the risk evaluation service to return an error status. This type of integration test dependency on external service behavior is a classic symptom of test flakiness.
No code changes are warranted because:
- The dependency update is unrelated to the test failure mechanism
- The test failure is environmental, not code-based
- Fixing would require investigation into the DaVinci flow configuration or PingOne Risk service behavior, not application code changes
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
ecb5495
to
4cba9ac
Compare
@forgerock/davinci-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
This PR contains the following updates:
10.1.1
->10.1.3
Release Notes
immerjs/immer (immer)
v10.1.3
Compare Source
Bug Fixes
v10.1.2
Compare Source
Bug Fixes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.