Release PR #345
Release PR #345
Conversation
|
View your CI Pipeline Execution ↗ for commit 3fe695e
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (18.75%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=========================================
+ Coverage 0 18.75% +18.75%
=========================================
Files 0 138 +138
Lines 0 27368 +27368
Branches 0 951 +951
=========================================
+ Hits 0 5132 +5132
- Misses 0 22236 +22236 🚀 New features to boost your workflow:
|
|
Deployed 338cae8 to https://ForgeRock.github.io/ping-javascript-sdk/pr-345/338cae8ccf13152e665939241d837d588465d4d5 branch gh-pages in ForgeRock/ping-javascript-sdk |
📦 Bundle Size Analysis📦 Bundle Size Analysis🚨 Significant Changes🔻 @forgerock/journey-client - 0.0 KB (-82.0 KB, -100.0%) ➖ No Changes➖ @forgerock/device-client - 9.2 KB 13 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
ryanbas21
force-pushed
the
changeset-release/main
branch
7 times, most recently
from
7f85e3d to
84aa034
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
6 times, most recently
from
d5812af to
997d98a
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
4 times, most recently
from
5eb620d to
954ce37
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
5 times, most recently
from
a5a72fb to
fae494a
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
3 times, most recently
from
1fceeb2 to
022b06c
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
022b06c to
625b514
Compare
WalkthroughDeletes many Changes
Sequence Diagram(s)Not applicable — changes are documentation and version bumps only; no control-flow modifications. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ryanbas21
force-pushed
the
changeset-release/main
branch
from
625b514 to
c0a7883
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/davinci-client/package.json (1)
9-9: sideEffects points to non-published src path; adjust for treeshaking correctness."files" publishes only dist/, but sideEffects references ./src/types.js, which won’t exist post-publish. Prefer sideEffects: false (or point to a dist file if there’s a real side effect).
Apply:
- "sideEffects": ["./src/types.js"], + "sideEffects": false,
🧹 Nitpick comments (4)
packages/sdk-utilities/package.json (1)
21-23: Optional: add top-level "types" for consistencyMost packages expose both exports.types and a top-level "types". Consider adding for tooling consistency.
Apply this diff:
"main": "./dist/src/index.js", "module": "./dist/src/index.js", + "types": "./dist/src/index.d.ts", "files": ["dist"],packages/protect/package.json (1)
23-27: Optional: add a build script for parity with other packagesEnables pnpm build to work uniformly.
"scripts": { + "build": "pnpm nx nxBuild", "lint": "pnpm nx nxLint", "test": "pnpm nx nxTest", "test:watch": "pnpm nx nxTest --watch" },packages/sdk-effects/sdk-request-middleware/CHANGELOG.md (1)
3-4: Optional: add a brief note under 1.3.0Even “No functional changes; version bump only.” helps consumers scanning releases.
packages/sdk-utilities/CHANGELOG.md (1)
3-4: Optional: add a brief note under 1.3.0Clarify if this is a version alignment only.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (33)
.changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/thin-nights-send.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (13)
- .changeset/calm-waves-change.md
- .changeset/fine-windows-search.md
- .changeset/dull-rockets-give.md
- .changeset/thin-nights-send.md
- .changeset/shiny-crabs-wish.md
- .changeset/public-cougars-sneeze.md
- .changeset/chubby-chairs-dream.md
- .changeset/moody-chefs-hammer.md
- .changeset/every-bottles-sleep.md
- .changeset/spotty-tires-admire.md
- .changeset/dirty-queens-design.md
- .changeset/icy-olives-make.md
- .changeset/small-rats-cut.md
🧰 Additional context used
📓 Path-based instructions (2)
packages/**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
packages/**/package.json: All packages must be ES modules (set "type": "module" in each package's package.json)
Use workspace:* for internal dependencies and catalog: for shared external dependencies in package manifests
Files:
packages/sdk-effects/logger/package.jsonpackages/sdk-effects/storage/package.jsonpackages/davinci-client/package.jsonpackages/sdk-effects/sdk-request-middleware/package.jsonpackages/sdk-types/package.jsonpackages/oidc-client/package.jsonpackages/sdk-utilities/package.jsonpackages/protect/package.jsonpackages/sdk-effects/iframe-manager/package.jsonpackages/sdk-effects/oidc/package.json
packages/davinci-client/**
📄 CodeRabbit inference engine (CLAUDE.md)
Use Redux Toolkit for state management within the davinci-client package
Files:
packages/davinci-client/package.jsonpackages/davinci-client/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (20)
packages/sdk-utilities/package.json (2)
3-3: Version bump LGTMMatches release plan; no manifest regressions observed.
1-33: Repo-wide verification: ESM + dependency spec policy — manual verification required
Automated check failed: sandbox reported "No package.json files found under packages/", so I couldn't verify other packages.
- Ensure every packages/**/package.json sets "type": "module".
- Ensure internal @forgerock/* dependencies use "workspace:*".
- Ensure external dependencies use "catalog:*".
File reviewed: packages/sdk-utilities/package.json — confirm other packages match this pattern.packages/sdk-types/package.json (1)
3-3: Version bump LGTMESM config intact; exports and types remain correct.
packages/protect/package.json (2)
3-3: Version set to 1.3.0 — LGTMManifest aligns with ESM and Nx target config.
9-9: Verify sideEffects path exists in published distEnsure packages/protect/dist/src/lib/signals-sdk.js is emitted by the build and included via "files": ["dist"], else tree-shaking hints may be ineffective or misleading.
packages/sdk-effects/oidc/package.json (1)
3-3: Version bump LGTMInternal deps correctly use workspace:*; ESM config set.
packages/sdk-effects/storage/package.json (1)
3-3: Version bump LGTMworkspace:* used for @forgerock/sdk-types; ESM config intact.
packages/sdk-effects/sdk-request-middleware/package.json (1)
3-3: Version bump LGTMExternal dependency uses catalog:, matching policy.
packages/davinci-client/package.json (1)
3-3: Version bump LGTM; manifest follows module/deps guidelines.
- "type": "module" present.
- RTK included as dependency per package guideline.
packages/sdk-effects/logger/package.json (2)
3-3: Version bump LGTM.No issues spotted with build scripts/exports aside from the types path noted below.
17-19: Export "./types" should point to the declaration file (.d.ts), not a .jsdist/ is missing so I can't confirm built declarations; src re-exports './lib/logger.types.js'. If declarations exist, update package.json:
- "./types": "./dist/src/types.js" + "./types": "./dist/src/types.d.ts"After building, confirm packages/sdk-effects/logger/dist/src/types.d.ts exists and update the export accordingly.
packages/sdk-effects/logger/CHANGELOG.md (1)
3-4: Changelog entry added; LGTM.packages/sdk-effects/iframe-manager/package.json (1)
3-3: Version bump LGTM; ESM/export config consistent.packages/protect/CHANGELOG.md (1)
3-8: New 1.3.0 changelog entry LGTM.packages/sdk-types/CHANGELOG.md (1)
3-8: Patch changelog additions LGTM.packages/oidc-client/CHANGELOG.md (1)
3-35: Changelog updates match the coordinated release; LGTM.packages/oidc-client/package.json (1)
3-3: Approve packages/[email protected] — quick repo checkspackages/oidc-client/package.json: version 1.3.0; type: module; all @forgerock/* deps use workspace:* — approve.
- Non-ESM package.json (confirm if deliberate): ./e2e/device-client-app/package.json, ./e2e/oidc-app/package.json, ./e2e/oidc-suites/package.json, ./package.json, ./tools/release/package.json, ./tools/user-scripts/package.json
- Files referencing @forgerock/javascript-sdk with pinned versions (not workspace:*):
- ./e2e/davinci-app/package.json -> 4.7.0
- ./e2e/device-client-app/package.json -> 4.7.0
- ./e2e/oidc-app/package.json -> ^4.8.2
- ./e2e/protect-app/package.json -> 4.7.0
- ./packages/device-client/package.json -> 4.7.0
If @forgerock/javascript-sdk is an internal workspace package, change those to workspace:*; otherwise no change needed.packages/sdk-effects/iframe-manager/CHANGELOG.md (1)
3-13: Changelog LGTM.
Clear, consistent with related OIDC updates.packages/davinci-client/CHANGELOG.md (1)
3-25: Changelog LGTM.
Content aligns with the 1.3.0 release scope and dependency updates.packages/sdk-effects/storage/CHANGELOG.md (1)
3-15: Changelog OK but workspace deps don't match 1.3.0 — reconcile package.json entriesChangelog entries look fine, but these package.json files reference workspace:* for internal @ForgeRock packages; update them to 1.3.0 or confirm workspace:* is intentional:
- e2e/davinci-app/package.json -> @forgerock/davinci-client@workspace:*
- e2e/davinci-app/package.json -> @forgerock/sdk-logger@workspace:*
- e2e/davinci-app/package.json -> @forgerock/protect@workspace:*
- e2e/oidc-app/package.json -> @forgerock/oidc-client@workspace:*
- e2e/oidc-app/package.json -> @forgerock/sdk-types@workspace:*
- e2e/protect-app/package.json -> @forgerock/protect@workspace:*
- packages/davinci-client/package.json -> @forgerock/sdk-logger@workspace:*
- packages/davinci-client/package.json -> @forgerock/sdk-oidc@workspace:*
- packages/davinci-client/package.json -> @forgerock/sdk-request-middleware@workspace:*
- packages/davinci-client/package.json -> @forgerock/sdk-types@workspace:*
- packages/davinci-client/package.json -> @forgerock/storage@workspace:*
- packages/oidc-client/package.json -> @forgerock/iframe-manager@workspace:*
- packages/oidc-client/package.json -> @forgerock/sdk-logger@workspace:*
- packages/oidc-client/package.json -> @forgerock/sdk-oidc@workspace:*
- packages/oidc-client/package.json -> @forgerock/sdk-request-middleware@workspace:*
- packages/oidc-client/package.json -> @forgerock/sdk-types@workspace:*
- packages/oidc-client/package.json -> @forgerock/storage@workspace:*
- packages/sdk-effects/oidc/package.json -> @forgerock/sdk-types@workspace:*
- packages/sdk-effects/oidc/package.json -> @forgerock/sdk-utilities@workspace:*
- packages/sdk-effects/storage/package.json -> @forgerock/sdk-types@workspace:*
Likely an incorrect or invalid review comment.
| ## 1.3.0 | ||
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#348](https://github.com/ForgeRock/ping-javascript-sdk/pull/348) [`beb349a`](https://github.com/ForgeRock/ping-javascript-sdk/commit/beb349a9a13e7bb8fbad35bf9bda9e340545cffa) Thanks [@cerebrl](https://github.com/cerebrl)! - Implemented token exchange within OIDC Client | ||
|
|
||
| - [#344](https://github.com/ForgeRock/ping-javascript-sdk/pull/344) [`dc4d4bd`](https://github.com/ForgeRock/ping-javascript-sdk/commit/dc4d4bdb5aa781660de631f45b22620e400d9f4a) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement authorize functionality in oidc-client | ||
| - Provide authorize URL method for URL creation | ||
| - Provide background method for authorization without redirection | ||
| - Introduce Micro from the Effect package | ||
|
|
||
| - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package | ||
| - Exposes `getStorageKey` utility | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - Updated dependencies [[`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c)]: | ||
| - @forgerock/sdk-types@1.3.0 | ||
| - @forgerock/sdk-utilities@1.3.0 | ||
|
|
There was a problem hiding this comment.
Fix extra hyphen in bullet list.
There’s a stray “-” before “Adds tests for OIDC effects package.”
Apply this diff:
- - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package
+ - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - Adds tests for OIDC effects package📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## 1.3.0 | |
| ### Minor Changes | |
| - [#348](https://github.com/ForgeRock/ping-javascript-sdk/pull/348) [`beb349a`](https://github.com/ForgeRock/ping-javascript-sdk/commit/beb349a9a13e7bb8fbad35bf9bda9e340545cffa) Thanks [@cerebrl](https://github.com/cerebrl)! - Implemented token exchange within OIDC Client | |
| - [#344](https://github.com/ForgeRock/ping-javascript-sdk/pull/344) [`dc4d4bd`](https://github.com/ForgeRock/ping-javascript-sdk/commit/dc4d4bdb5aa781660de631f45b22620e400d9f4a) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement authorize functionality in oidc-client | |
| - Provide authorize URL method for URL creation | |
| - Provide background method for authorization without redirection | |
| - Introduce Micro from the Effect package | |
| - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package | |
| - Exposes `getStorageKey` utility | |
| ### Patch Changes | |
| - Updated dependencies [[`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c)]: | |
| - @forgerock/sdk-types@1.3.0 | |
| - @forgerock/sdk-utilities@1.3.0 | |
| ## 1.3.0 | |
| ### Minor Changes | |
| - [#348](https://github.com/ForgeRock/ping-javascript-sdk/pull/348) [`beb349a`](https://github.com/ForgeRock/ping-javascript-sdk/commit/beb349a9a13e7bb8fbad35bf9bda9e340545cffa) Thanks [@cerebrl](https://github.com/cerebrl)! - Implemented token exchange within OIDC Client | |
| - [#344](https://github.com/ForgeRock/ping-javascript-sdk/pull/344) [`dc4d4bd`](https://github.com/ForgeRock/ping-javascript-sdk/commit/dc4d4bdb5aa781660de631f45b22620e400d9f4a) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement authorize functionality in oidc-client | |
| - Provide authorize URL method for URL creation | |
| - Provide background method for authorization without redirection | |
| - Introduce Micro from the Effect package | |
| - [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - Adds tests for OIDC effects package | |
| - Exposes `getStorageKey` utility | |
| ### Patch Changes | |
| - Updated dependencies [[`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c)]: | |
| - @forgerock/sdk-types@1.3.0 | |
| - @forgerock/sdk-utilities@1.3.0 |
🤖 Prompt for AI Agents
In packages/sdk-effects/oidc/CHANGELOG.md around lines 3 to 22, there is a stray
extra hyphen before the "Adds tests for OIDC effects package" bullet that makes
the list render as "- - Adds tests..."; remove the extra leading hyphen so the
line is a single list item (i.e., convert the double-hyphen bullet into a
single-hyphen bullet and ensure indentation/spacing matches the surrounding list
entries).
c0a7883 to
2c852bb
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/sdk-effects/iframe-manager/CHANGELOG.md (2)
7-7: Align naming with package identifierUse a consistent reference to the package, e.g.,
@forgerock/oidc-client(or “OIDC client”) instead of mixing “OIDC Client” and “oidc-client” elsewhere.-- Implemented token exchange within OIDC Client +- Implemented token exchange in `@forgerock/oidc-client`
9-12: Tighten wording and casing for sub-bulletsMake the bullets parallel, concise, and consistent; consider using the package name inline and simplifying phrasing.
-- Implement authorize functionality in oidc-client - - Provide authorize URL method for URL creation - - Provide background method for authorization without redirection - - Introduce Micro from the Effect package +- Implement authorization features in `@forgerock/oidc-client` + - Added authorize URL builder method + - Added background authorization (no redirect) + - Introduced Micro from Effectpackages/sdk-effects/oidc/package.json (1)
3-3: Version bump looks good; ESM and workspace dependency usage compliant.
- "type": "module" present; internal deps use "workspace:*".
- Optional: consider adding "files": ["dist"] to reduce publish size.
packages/sdk-utilities/package.json (1)
3-3: Add top-level "types" field for tooling consistency.Other packages expose "types" at the root; this one relies only on exports.types. Recommend adding:
{
"types": "./dist/src/index.d.ts"
}packages/oidc-client/CHANGELOG.md (1)
7-25: Fix grammar and casing in Minor Changes bulletsSeveral entries have minor grammar/casing issues; update for clarity and consistency (notably Line 16’s “replaced to” is ungrammatical).
Apply this diff:
- - [#344](https://github.com/ForgeRock/ping-javascript-sdk/pull/344) [`dc4d4bd`](https://github.com/ForgeRock/ping-javascript-sdk/commit/dc4d4bdb5aa781660de631f45b22620e400d9f4a) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement authorize functionality in oidc-client - - Provide authorize URL method for URL creation - - Provide background method for authorization without redirection - - Introduce Micro from the Effect package + - [#344](https://github.com/ForgeRock/ping-javascript-sdk/pull/344) [`dc4d4bd`](https://github.com/ForgeRock/ping-javascript-sdk/commit/dc4d4bdb5aa781660de631f45b22620e400d9f4a) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement authorize functionality in OIDC Client: + - Provide authorize URL method for URL creation + - Provide background method for authorization without redirection + - Introduce `Micro` from the `Effect` package - - [#402](https://github.com/ForgeRock/ping-javascript-sdk/pull/402) [`bdbbbd2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/bdbbbd28af3f56393d12feb63d0c353ba7c89fa1) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement force renew and revoke tokens that are replaced to tokens.get method + - [#402](https://github.com/ForgeRock/ping-javascript-sdk/pull/402) [`bdbbbd2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/bdbbbd28af3f56393d12feb63d0c353ba7c89fa1) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement force-renew and revoke; integrate with `tokens.get` - - [#368](https://github.com/ForgeRock/ping-javascript-sdk/pull/368) [`5fe1f95`](https://github.com/ForgeRock/ping-javascript-sdk/commit/5fe1f95667761a6a35b69e0b278e086e7cbc7e98) Thanks [@ancheetah](https://github.com/ancheetah)! - Added tests for oidc client + - [#368](https://github.com/ForgeRock/ping-javascript-sdk/pull/368) [`5fe1f95`](https://github.com/ForgeRock/ping-javascript-sdk/commit/5fe1f95667761a6a35b69e0b278e086e7cbc7e98) Thanks [@ancheetah](https://github.com/ancheetah)! - Added tests for OIDC Client - - [#363](https://github.com/ForgeRock/ping-javascript-sdk/pull/363) [`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement OIDC logout and user info request; includes type updates and global error type + - [#363](https://github.com/ForgeRock/ping-javascript-sdk/pull/363) [`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement OIDC logout and user info request; includes type updates and a global error type - - [#369](https://github.com/ForgeRock/ping-javascript-sdk/pull/369) [`7cb0519`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7cb0519b833ec8094a57cc20c4183fc4e521e132) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement token `get` method for local tokens and autorenew + - [#369](https://github.com/ForgeRock/ping-javascript-sdk/pull/369) [`7cb0519`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7cb0519b833ec8094a57cc20c4183fc4e521e132) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement token `get` method for local tokens and auto‑renew
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (33)
.changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/thin-nights-send.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (13)
- .changeset/dirty-queens-design.md
- .changeset/public-cougars-sneeze.md
- .changeset/small-rats-cut.md
- .changeset/thin-nights-send.md
- .changeset/calm-waves-change.md
- .changeset/fine-windows-search.md
- .changeset/spotty-tires-admire.md
- .changeset/shiny-crabs-wish.md
- .changeset/icy-olives-make.md
- .changeset/every-bottles-sleep.md
- .changeset/chubby-chairs-dream.md
- .changeset/moody-chefs-hammer.md
- .changeset/dull-rockets-give.md
✅ Files skipped from review due to trivial changes (5)
- packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
- packages/davinci-client/CHANGELOG.md
- packages/sdk-effects/sdk-request-middleware/package.json
- packages/protect/CHANGELOG.md
- packages/sdk-effects/storage/package.json
🚧 Files skipped from review as they are similar to previous changes (10)
- packages/sdk-types/CHANGELOG.md
- packages/sdk-effects/storage/CHANGELOG.md
- packages/oidc-client/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/protect/package.json
- packages/davinci-client/package.json
- packages/sdk-utilities/CHANGELOG.md
- packages/sdk-effects/logger/package.json
- packages/sdk-effects/oidc/CHANGELOG.md
- packages/sdk-effects/logger/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/**/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
packages/**/package.json: All packages must be ES modules (set "type": "module" in each package's package.json)
Use workspace:* for internal dependencies and catalog: for shared external dependencies in package manifests
Files:
packages/sdk-effects/oidc/package.jsonpackages/sdk-types/package.jsonpackages/sdk-utilities/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (5)
packages/sdk-effects/iframe-manager/CHANGELOG.md (1)
7-12: Verify PR and commit references resolvePlease double-check that PR links and commit SHAs are valid and correspond to the described changes.
packages/sdk-types/package.json (1)
3-3: LGTM on version bump and config.
- ESM set via "type": "module".
- No external deps; manifest aligns with guidelines.
packages/oidc-client/CHANGELOG.md (3)
3-6: 1.3.0 section header and structure look goodNo issues with the new section header and headings.
26-35: Changelog dependency versions match package.json All listed @ForgeRock packages are confirmed at 1.3.0.
7-25: All referenced PRs and commit hashes are valid – every link and SHA resolves successfully.
ryanbas21
force-pushed
the
changeset-release/main
branch
from
2c852bb to
c168b40
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (33)
.changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/thin-nights-send.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (13)
- .changeset/dull-rockets-give.md
- .changeset/shiny-crabs-wish.md
- .changeset/thin-nights-send.md
- .changeset/small-rats-cut.md
- .changeset/spotty-tires-admire.md
- .changeset/chubby-chairs-dream.md
- .changeset/fine-windows-search.md
- .changeset/calm-waves-change.md
- .changeset/icy-olives-make.md
- .changeset/public-cougars-sneeze.md
- .changeset/every-bottles-sleep.md
- .changeset/dirty-queens-design.md
- .changeset/moody-chefs-hammer.md
✅ Files skipped from review due to trivial changes (2)
- packages/davinci-client/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (12)
- packages/sdk-effects/logger/CHANGELOG.md
- packages/davinci-client/package.json
- packages/sdk-effects/iframe-manager/package.json
- packages/sdk-effects/storage/package.json
- packages/sdk-effects/oidc/package.json
- packages/sdk-effects/logger/package.json
- packages/oidc-client/CHANGELOG.md
- packages/sdk-effects/storage/CHANGELOG.md
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- packages/sdk-utilities/package.json
- packages/sdk-effects/sdk-request-middleware/package.json
- packages/sdk-effects/oidc/CHANGELOG.md
🔇 Additional comments (5)
packages/sdk-effects/sdk-request-middleware/CHANGELOG.md (1)
3-4: Empty 1.3.0 version header—verify whether changelog content is missing.The new 1.3.0 section has no content describing what changed in this release. While the PR objectives list
@forgerock/[email protected]as part of the release, no specific changes (minor or patch) are documented here, unlike other packages in this PR that have detailed changelog entries.If this package genuinely has no functional changes and is only being bumped for consistency with other packages, consider adding a note such as:
## 1.3.0 + +### Patch Changes + +- Version bump for consistency with other packages in the monorepo.Otherwise, please add the appropriate changelog content documenting what changed in this version.
packages/protect/package.json (1)
3-3: LGTM! Version bump aligns with the coordinated 1.3.0 release.The version bump from 0.0.0 to 1.3.0 is consistent with the release PR objectives and the corresponding CHANGELOG.md entry documenting the implementation of the ping protect package.
packages/protect/CHANGELOG.md (1)
1-8: LGTM! Changelog entry is well-formatted and consistent with the release.The changelog properly documents the 1.3.0 release with appropriate structure, attribution, and description of the ping protect package implementation. The entry aligns with the version bump in package.json.
packages/sdk-types/package.json (1)
3-3: LGTM! Version bump is consistent with the release.The version bump from 1.2.0 to 1.3.0 aligns with the automated release process and the changes documented in the corresponding CHANGELOG.md.
packages/oidc-client/package.json (1)
3-3: LGTM! Version bump is consistent with the release.The version bump to 1.3.0 aligns with the automated release process. The workspace dependencies will be properly resolved to concrete versions during the publish step.
| ## 1.3.0 | ||
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#363](https://github.com/ForgeRock/ping-javascript-sdk/pull/363) [`6c06e70`](https://github.com/ForgeRock/ping-javascript-sdk/commit/6c06e709a7aa503cda2e4f2b923cace1abcebd3c) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement OIDC logout and user info request; includes type updates and global error type | ||
|
|
There was a problem hiding this comment.
🧩 Analysis chain
Verify the semantic versioning classification.
The version is bumped to 1.3.0 (minor), but the changes are classified as "Patch Changes". While this can be correct if the minor bump is driven by other packages in the monorepo, please confirm this aligns with your versioning strategy—especially since the PR objectives indicate this is a minor release with new features across multiple packages.
🏁 Script executed:
#!/bin/bash
# Description: Check if other packages in this release have Minor Changes that justify the 1.3.0 bump
# Search for Minor Changes sections in CHANGELOG files for version 1.3.0
echo "=== Checking for Minor Changes in 1.3.0 across packages ==="
fd -e md -x grep -l "## 1.3.0" | xargs -I {} sh -c 'echo "File: {}" && sed -n "/## 1.3.0/,/## [0-9]/p" {} | grep -A 2 "### Minor Changes" || echo "No Minor Changes found"'Length of output: 2371
Replace "Patch Changes" with "Minor Changes" in packages/sdk-types/CHANGELOG.md
The OIDC logout and user info request are new feature additions and should be listed under Minor Changes for version 1.3.0.
🤖 Prompt for AI Agents
In packages/sdk-types/CHANGELOG.md around lines 3 to 8, the section heading
"Patch Changes" is incorrect for new feature additions; replace the heading text
"Patch Changes" with "Minor Changes" so the OIDC logout and user info request
entry is categorized correctly under Minor Changes and ensure the surrounding
Markdown formatting and capitalization remain consistent.
04fb775 to
35eb7b1
Compare
ryanbas21
force-pushed
the
changeset-release/main
branch
from
35eb7b1 to
3fe695e
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
packages/sdk-effects/oidc/CHANGELOG.md (1)
14-14: Fix extra hyphen in bullet list.Line 14 still has a stray "-" before "Adds tests for OIDC effects package" that was flagged in the previous review. This creates incorrect markdown rendering.
Apply this diff:
-- [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - - Adds tests for OIDC effects package +- [#416](https://github.com/ForgeRock/ping-javascript-sdk/pull/416) [`7ffa428`](https://github.com/ForgeRock/ping-javascript-sdk/commit/7ffa428b0fda63d978e181cd5c9150777d863f40) Thanks [@ancheetah](https://github.com/ancheetah)! - Adds tests for OIDC effects package
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (43)
.changeset/breezy-actors-sell.md(0 hunks).changeset/bright-lights-yawn.md(0 hunks).changeset/calm-waves-change.md(0 hunks).changeset/chubby-chairs-dream.md(0 hunks).changeset/dirty-queens-design.md(0 hunks).changeset/dull-rockets-give.md(0 hunks).changeset/every-bottles-sleep.md(0 hunks).changeset/fine-windows-search.md(0 hunks).changeset/good-games-accept.md(0 hunks).changeset/icy-olives-make.md(0 hunks).changeset/kind-guests-sneeze.md(0 hunks).changeset/moody-chefs-hammer.md(0 hunks).changeset/orange-peaches-warn.md(0 hunks).changeset/public-cougars-sneeze.md(0 hunks).changeset/shiny-crabs-wish.md(0 hunks).changeset/slow-teeth-melt.md(0 hunks).changeset/small-rats-cut.md(0 hunks).changeset/spotty-tires-admire.md(0 hunks).changeset/tender-schools-scream.md(0 hunks).changeset/thin-nights-send.md(0 hunks).changeset/wild-items-stop.md(0 hunks)packages/davinci-client/CHANGELOG.md(1 hunks)packages/davinci-client/package.json(1 hunks)packages/journey-client/CHANGELOG.md(1 hunks)packages/journey-client/package.json(1 hunks)packages/oidc-client/CHANGELOG.md(1 hunks)packages/oidc-client/package.json(1 hunks)packages/protect/CHANGELOG.md(1 hunks)packages/protect/package.json(1 hunks)packages/sdk-effects/iframe-manager/CHANGELOG.md(1 hunks)packages/sdk-effects/iframe-manager/package.json(1 hunks)packages/sdk-effects/logger/CHANGELOG.md(1 hunks)packages/sdk-effects/logger/package.json(1 hunks)packages/sdk-effects/oidc/CHANGELOG.md(1 hunks)packages/sdk-effects/oidc/package.json(1 hunks)packages/sdk-effects/sdk-request-middleware/CHANGELOG.md(1 hunks)packages/sdk-effects/sdk-request-middleware/package.json(1 hunks)packages/sdk-effects/storage/CHANGELOG.md(1 hunks)packages/sdk-effects/storage/package.json(1 hunks)packages/sdk-types/CHANGELOG.md(1 hunks)packages/sdk-types/package.json(1 hunks)packages/sdk-utilities/CHANGELOG.md(1 hunks)packages/sdk-utilities/package.json(1 hunks)
💤 Files with no reviewable changes (21)
- .changeset/spotty-tires-admire.md
- .changeset/orange-peaches-warn.md
- .changeset/slow-teeth-melt.md
- .changeset/moody-chefs-hammer.md
- .changeset/dirty-queens-design.md
- .changeset/bright-lights-yawn.md
- .changeset/calm-waves-change.md
- .changeset/icy-olives-make.md
- .changeset/shiny-crabs-wish.md
- .changeset/thin-nights-send.md
- .changeset/public-cougars-sneeze.md
- .changeset/tender-schools-scream.md
- .changeset/dull-rockets-give.md
- .changeset/wild-items-stop.md
- .changeset/every-bottles-sleep.md
- .changeset/chubby-chairs-dream.md
- .changeset/good-games-accept.md
- .changeset/fine-windows-search.md
- .changeset/kind-guests-sneeze.md
- .changeset/small-rats-cut.md
- .changeset/breezy-actors-sell.md
✅ Files skipped from review due to trivial changes (3)
- packages/protect/CHANGELOG.md
- packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
- packages/sdk-utilities/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (9)
- packages/sdk-effects/sdk-request-middleware/package.json
- packages/sdk-types/CHANGELOG.md
- packages/journey-client/package.json
- packages/sdk-effects/storage/CHANGELOG.md
- packages/oidc-client/package.json
- packages/sdk-effects/iframe-manager/CHANGELOG.md
- packages/sdk-effects/storage/package.json
- packages/sdk-types/package.json
- packages/sdk-effects/iframe-manager/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
🔇 Additional comments (5)
packages/davinci-client/package.json (1)
3-3: LGTM! Standard minor version bump.The version increment from 1.2.0 to 1.3.0 aligns with the new features described in the PR objectives (token exchange, Ping Protect collector, OIDC logout/userinfo).
packages/sdk-utilities/package.json (1)
3-3: LGTM! Minor version bump is appropriate.The version increment correctly reflects the minor improvements described in the changelog (inlined constants for better tree-shaking and type narrowing).
packages/protect/package.json (1)
3-3: Verify the version jump from 0.0.0 to 1.3.0.The package is jumping from 0.0.0 directly to 1.3.0, which is unusual. This appears to be intentional to align the new Ping Protect package with the rest of the monorepo's version scheme. While this maintains consistency across packages, confirm this aligns with your versioning strategy for new packages.
packages/sdk-effects/oidc/package.json (1)
3-3: LGTM! Version bump aligns with new features.The minor version increment is appropriate for the new features described in the PR objectives (token exchange, authorize functionality, getStorageKey exposure).
packages/sdk-effects/logger/package.json (1)
3-3: LGTM! Standard minor version bump.The version increment from 1.2.0 to 1.3.0 is consistent with the coordinated release across all @ForgeRock packages.
| - [#417](https://github.com/ForgeRock/ping-javascript-sdk/pull/417) [`93595d2`](https://github.com/ForgeRock/ping-javascript-sdk/commit/93595d265234cd149ff76dbac20e3e1031c3ef5f) Thanks [@ancheetah](https://github.com/ancheetah)! - - Standardizes return types on storage client and updates tests | ||
| - Improves OIDC client where storage client methods are used |
There was a problem hiding this comment.
Fix the stray hyphen in the changelog entry.
Line 22 currently reads “- - Standardizes…”, so it renders with an extra hyphen in the published notes. Drop the extra hyphen so the bullet renders cleanly.
🤖 Prompt for AI Agents
packages/oidc-client/CHANGELOG.md lines 22-23: the changelog entry has a stray
extra hyphen ("- - Standardizes…") causing a double bullet; edit line 22 to
remove the extra hyphen so it reads a single hyphen or proper bullet ("-
Standardizes...") ensuring the bullet renders correctly in the published notes.
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
The failing tests are end-to-end authentication tests in the @forgerock/davinci-suites package that are unable to complete authentication flows, expecting UI elements like "Complete" text and auth codes that are not appearing.
This PR is an automated Changesets release that only bumps package versions from 1.2.x to 1.3.0 across the monorepo and updates changelogs. There are no functional code changes that could logically cause authentication service failures.
The failures are classified as 'environment_state' because:
- Version-only changes cannot cause authentication flow failures
- All failures occur at authentication completion stages, suggesting external service availability issues
- The authentication service or test environment setup appears to be unavailable or misconfigured
- No explicit code-level errors, syntax issues, or import problems are present
Since these are environmental issues unrelated to the PR's version bump changes, no code fixes are warranted. The test failures should be resolved by addressing the underlying authentication service or test environment configuration issues.
A code change would likely not resolve this issue, so no action was taken.
⚙️ An Nx Cloud workspace admin can disable these reviews in workspace settings.
2 participants
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#340
0fa522aThanks @ancheetah! - Implemented Ping Protect collector#396
036f495Thanks @ancheetah! - Added support for pre-filled phone number and country codePatch Changes
#413
9213bb9Thanks @ancheetah! - ExposesrequiredandvalidatePhoneNumberproperties on collectors#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error typeUpdated dependencies [
b0f4368,beb349a,dc4d4bd,7ffa428,6c06e70,93595d2,b0f4368,b0f4368]:@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#376
c48d9c8Thanks @ancheetah! - Implement tokenrevokemethod#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#402
bdbbbd2Thanks @cerebrl! - Implement force renew and revoke tokens that are replaced to tokens.get method#368
5fe1f95Thanks @ancheetah! - Added tests for oidc client#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error type#417
93595d2Thanks @ancheetah! - - Standardizes return types on storage client and updates tests#378
4d0ee71Thanks @cerebrl! - Migrate /authorize to RTK Query and improve result types#369
7cb0519Thanks @cerebrl! - Implement tokengetmethod for local tokens and autorenewPatch Changes
b0f4368,beb349a,dc4d4bd,b0f4368,7ffa428,6c06e70,93595d2,b0f4368,b0f4368]:@forgerock/[email protected]
Minor Changes
18677d9Thanks @ancheetah! - Implemented ping protect package@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#412
b0f4368Thanks @ryanbas21! - feat: Update iframe-managerverbatimModuleSyntaxby correcting type-only imports and module exports.@forgerock/[email protected]
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK loggerverbatimModuleSyntaxby correcting type-only imports and module exports.@forgerock/[email protected]
Minor Changes
#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#344
dc4d4bdThanks @cerebrl! - Implement authorize functionality in oidc-client#416
7ffa428Thanks @ancheetah! - - Adds tests for OIDC effects packagegetStorageKeyutilityPatch Changes
b0f4368,6c06e70,b0f4368]:@forgerock/[email protected]
Minor Changes
#412
b0f4368Thanks @ryanbas21! - feat: Update storage packageverbatimModuleSyntaxby correcting type-only imports and module exports.#348
beb349aThanks @cerebrl! - Implemented token exchange within OIDC Client#417
93595d2Thanks @ancheetah! - - Standardizes return types on storage client and updates testsPatch Changes
#363
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error typeUpdated dependencies [
6c06e70,b0f4368]:@forgerock/[email protected]
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK typesverbatimModuleSyntaxby correcting type-only imports and module exports.Patch Changes
6c06e70Thanks @cerebrl! - Implement OIDC logout and user info request; includes type updates and global error type@forgerock/[email protected]
Minor Changes
b0f4368Thanks @ryanbas21! - feat: Update SDK utilitiesREQUESTED_WITHandX_REQUESTED_PLATFORMconstants with literal types for better tree-shaking and type narrowing.@forgerock/[email protected]
@forgerock/[email protected]
Minor Changes
#412
b0f4368Thanks @ryanbas21! - feat: Implement new journey clientjourney()factory function for creating stateful client instances.resumelogic to correctly persist and retrieve plainSteppayloads, resolving prototype loss issues during serialization.#412
b0f4368Thanks @ryanbas21! - feat(journey-client): Add WebAuthn, QR Code, and Recovery Code supportFRWebAuthn,FRQRCode,FRRecoveryCodes) to handle advanced authentication methods within authentication journeys.TextOutputCallbackwas being incorrectly inferred asTextInputCallback.Patch Changes
b0f4368,b0f4368,beb349a,6c06e70,93595d2,b0f4368,b0f4368]:Summary by CodeRabbit
New Features
Improvements
Documentation
Chores