Skip to content

Conversation

@CarloLucibello
Copy link
Member

Fixing compat bounds impeding tagging (JuliaRegistries/General#25139)

@devmotion
Copy link
Contributor

@CarloLucibello It would be great to get this fix into Tracker and release a new version. As long as Tracker is not compatible with SpecialFunctions 1, our tests in the Turing ecosystem won't actually run with SpecialFunctions 1 and we can't be sure that compat updates don't break anything. I just ran the tests locally successfully with your compat bounds on Julia 1.3, so maybe some dependencies were updated and it is sufficient to rerun the tests here?

@CarloLucibello
Copy link
Member Author

CarloLucibello commented Dec 11, 2020

let's try, then I'll need @DhairyaLGandhi to merge this, I don't have write access in this repo

@devmotion
Copy link
Contributor

devmotion commented Dec 11, 2020

Ah wait, I just saw that Tracker has a Manifest.toml checked in. I guess I updated that one by running ] up. Maybe remove it?

@CarloLucibello
Copy link
Member Author

n-th time I see a Manifest induced problem, I'll remove and .gitignore it

@ChrisRackauckas ChrisRackauckas merged commit f122c28 into FluxML:master Dec 12, 2020
@CarloLucibello
Copy link
Member Author

@ChrisRackauckas could you tag a release? version is already bumped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants