Allow batched_mul to work through PermutedDimsArray, II #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2020
mcabbott
pushed a commit
to mcabbott/CuArrays.jl
that referenced
this pull request
Apr 3, 2020
2 tasks
|
Bump. Who has merge permissions here? @CarloLucibello, @DhairyaLGandhi? |
mcabbott
pushed a commit
to mcabbott/CUDA.jl
that referenced
this pull request
Oct 24, 2020
|
ops, didn't see this, thanks |
|
Thanks! |
mcabbott
pushed a commit
to mcabbott/CUDA.jl
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #187.
It similarly allows
batched_multo work on manyPermutedDimsArrays, but does this just by callingstrides(A)and branching. It also extendsbatched_mul!to takeα, βscales likemul!.It adds two functions
storage_typeandis_strided, both of which recursively unwrap things. This avoids trying to dispatch onBatchedAdjoint{PermutedDimsArray{...,CuArray}}... instead it can separately check the underlying storage, and whether it should be safe to callstrides(A).It also improves
batched_gemm!to multi-thread the batch index (using JuliaLang/julia#36360 to save & restore the number of BLAS threads), and to allowsize(A,3)==1(batch only B,C).