Skip to content
This repository was archived by the owner on Sep 6, 2025. It is now read-only.

Conversation

@pc223
Copy link
Contributor

@pc223 pc223 commented Jul 21, 2021

@taooceros Do you want to handle icons like this? Add the glyph directly in the json file?

I managed to get some of the icon out of this file, a lot still missing, I'll try a bit more later

C:\Windows\ImmersiveControlPanel\Settings\AllSystemSettings_{253E530E-387D-4BC2-959D-E6F86122E5F2}.xml

@pc223 pc223 marked this pull request as draft July 21, 2021 19:55
@pc223 pc223 marked this pull request as ready for review July 21, 2021 19:55
@taooceros
Copy link
Member

Wow, interesting. Will take a look soon.

@taooceros
Copy link
Member

taooceros commented Jul 23, 2021

I check the glyph. It may requires more edition for now (add a property for Result display in ResultListView). We need to make a proposal for that in Flow because these glyph requires extra assets font.

@pc223
Copy link
Contributor Author

pc223 commented Jul 23, 2021

I check the glyph. It may requires more edition for now (add a property for Result display in ResultListView). We need to make a proposal for that in Flow because these glyph requires extra assets font.

Yeah, it's this font

https://docs.microsoft.com/en-us/windows/apps/design/style/segoe-ui-symbol-font

@taooceros
Copy link
Member

I check for dynamic font import. It looks like it is possible to directly import a ttf into the application, but it also contains an issue that needs to be aware.
https://stackoverflow.com/questions/48609956/change-font-family-programmatically-in-wpf
https://stackoverflow.com/questions/31452443/wpf-textblock-memory-leak-when-using-font

@taooceros
Copy link
Member

@pc223 Could you add glyph to a different field in the json, because the glyph may require a special font family.

@pc223
Copy link
Contributor Author

pc223 commented Jul 31, 2021

@pc223 Could you add glyph to a different field in the json, because the glyph may require a special font family.

Like this?

{
	...
	"IconGlyph": { 
		"Glyph": "\ue8d7",
		"FontFamily": "Segoe MDL2 Assets"
	}
	...
}

@taooceros
Copy link
Member

@pc223 Do you want to finish the glyph icon results by yourselves? I can handle it if that's too hard😃.

@pc223
Copy link
Contributor Author

pc223 commented Sep 29, 2021

@pc223 Do you want to finish the glyph icon results by yourselves? I can handle it if that's too hard😃.

Yeah, you just go ahead and complete this I think 😄 It's enough for early release, I'll look closer later to see if I can get some more glyphs, for now still quite a bit missing 😄

@taooceros
Copy link
Member

I will merge it first

@taooceros taooceros merged commit e981139 into main Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants