[dev] Global hotkey refactor

[taooceros]

fix #788

[jjw24]

@taooceros fair bit of method signature changes. can you give me a quick overview of why they are changed please

[taooceros]

@taooceros fair bit of method signature changes. can you give me a quick overview of why they are changed please

Only the global hotkey event in publicapi is obsolete, and two new api is added to handle the same work.

[taooceros]

Unsafe is used because

1. It's reasonable to have high performance here because every key hit will trigger the running of the function once.
2. I would like to try the new function pointer feature🤔😂
3. I am not sure whether some issues may exist because of unsafe, so we should take a small set of testing here. However, it is unlikely we need to unload assembly for infrastructure, so it should be fine.

[jjw24]

what's been tested with this change so far?

also need to bump Shell plugin

[onesounds]

what's been tested with this change so far?

also need to bump Shell plugin

It is a pr to solve the problem that when win+r is pressed, the flow closes and the run command (win+r by os) operates. I understand that the code has become complicated because there is a part in the middle of the work that does not work properly related to animation. I kept testing by pressing win+r in several situations.

[jjw24]

well i dont exactly understand this change, so if @taooceros is sure this is good to go and not going to break anything then happy for one of you to approve and merge this.

[taooceros]

well i dont exactly understand this change, so if @taooceros is sure this is good to go and not going to break anything then happy for one of you to approve and merge this.

The main change is because the multicast delegate (event) fails to return all return values so that the win+r may not work with the presence of the windows walker. The main change of the pull request change the event to a list of Func to retrieve the return value correctly.
Also, because c# 9 added the function pointer, so I think it's cool to use that in the hook for better performance because the hook is fired in every single keyboard click.

[jjw24]

somehow the artifacts are smaller, doesnt seem normal.

[Garulf]

• Build looks good
• Win+R fixed
• Fix for Tab complete
• Working with Window Walker
• No crashes

Good to go?

fixed

[jjw24]

unsure of code changes but tested working fine, will merge since this addresses an issue in current dev